Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Jun 4, 2022

wrapper PR for #15280 by @wdlingit which fixes the trivial code style issues that were introduced

@boegel boegel added the bug fix label Jun 4, 2022
@boegel boegel added this to the next release (4.5.5?) milestone Jun 4, 2022
@boegel
Copy link
Member Author

boegel commented Jun 4, 2022

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15615 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_15615 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8652

Test results coming soon (I hope)...

- notification for comment with ID 1146641225 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/459e150458cdf6cc3c19aded2b952c7a for a full test report.

@boegel
Copy link
Member Author

boegel commented Jun 4, 2022

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3108.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/b10ed6edbe570671713e1b7731f1c575 for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Jun 4, 2022

Going in, thanks @boegel!

@Micket Micket merged commit 0e5475c into easybuilders:develop Jun 4, 2022
@boegel boegel deleted the 15279_repeatmasker_config_after_install branch June 4, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants