Skip to content

Conversation

@akesandgren
Copy link
Contributor

@akesandgren akesandgren commented Oct 26, 2021

(created using eb --new-pr)

This fixes the issue reported in easybuilders/easybuild-easyblocks#2608

@akesandgren
Copy link
Contributor Author

@boegelbot Please test @ generoso

@boegelbot
Copy link
Collaborator

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=14212 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14212 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7150

Test results coming soon (I hope)...

- notification for comment with ID 952196889 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/1c58e4935babbcd49745078d15d7696f for a full test report.

@boegel boegel changed the title Improve GROMACS CPU detection. add patch for GROMACS 2019.3 easyconfigs using CMake 3.15.3 to fix CPU detection Oct 27, 2021
@boegel boegel modified the milestones: 4.x, 4.5.0 (next release) Oct 27, 2021
@boegel
Copy link
Member

boegel commented Oct 27, 2021

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node2635.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/2074fc8527df9b29eb53ee8051643480 for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Oct 27, 2021

Going in, thanks @akesandgren!

@boegel boegel merged commit 66d7dce into easybuilders:develop Oct 27, 2021
@akesandgren akesandgren deleted the 20211026201708_new_pr_GROMACS20193 branch October 27, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants