Skip to content

add patch for OpenBLAS 0.3.17 + 0.3.18 to fix segfault triggered by scipy tests #14178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2021
Merged

add patch for OpenBLAS 0.3.17 + 0.3.18 to fix segfault triggered by scipy tests #14178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion easybuild/easyconfigs/o/OpenBLAS/OpenBLAS-0.3.17-GCC-11.2.0.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,16 @@ sources = ['v%(version)s.tar.gz']
patches = [
('large.tgz', '.'),
('timing.tgz', '.'),
'%(name)s-%(version)s_workaround-gcc11-miscompiling-C-ZBLAS3-tests.patch',
'OpenBLAS-%(version)s_workaround-gcc11-miscompiling-C-ZBLAS3-tests.patch',
'OpenBLAS-%(version)s_fix-segfault-ztrsv.patch',
]
checksums = [
'df2934fa33d04fd84d839ca698280df55c690c86a5a1133b3f7266fce1de279f', # v0.3.17.tar.gz
'f328d88b7fa97722f271d7d0cfea1c220e0f8e5ed5ff01d8ef1eb51d6f4243a1', # large.tgz
'999c65f8ea8bd4eac7f1c7f3463d4946917afd20a997807300fe35d70122f3af', # timing.tgz
# OpenBLAS-0.3.17_workaround-gcc11-miscompiling-C-ZBLAS3-tests.patch
'ea76320bc047eff1bf2a2f50c1c19acb4fd6d2b8a5bf81a4dce73145a2a5cfcb',
'b1f89d90cc46b486534069135854e6081994b5a1a88370d32dae982e0f040111', # OpenBLAS-0.3.17_fix-segfault-ztrsv.patch
]

# extensive testing can be enabled by uncommenting the line below
Expand Down
29 changes: 29 additions & 0 deletions easybuild/easyconfigs/o/OpenBLAS/OpenBLAS-0.3.17_fix-segfault-ztrsv.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
fix segmentation fault triggered via scipy tests
and https://github.com/xianyi/OpenBLAS/issues/3419 + https://github.com/xianyi/OpenBLAS/pull/3420
From 2845f54eb8ad4c79d0374b52cceac434fc93d8ac Mon Sep 17 00:00:00 2001
From: Martin Kroeker <[email protected]>
Date: Wed, 20 Oct 2021 10:50:02 +0200
Subject: [PATCH] Remove dangerous optimization from previous #3252 - buffer is
never unused here

---
interface/ztrsv.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/interface/ztrsv.c b/interface/ztrsv.c
index cf750b0b0c..cbb7bba13b 100644
--- a/interface/ztrsv.c
+++ b/interface/ztrsv.c
@@ -199,12 +199,6 @@ void CNAME(enum CBLAS_ORDER order, enum CBLAS_UPLO Uplo,

if (n == 0) return;

- if (incx == 1 && trans == 0 && n < 50) {
- buffer = NULL;
- (trsv[(trans<<2) | (uplo<<1) | unit])(n, a, lda, x, incx, buffer);
- return;
- }
-
IDEBUG_START;

FUNCTION_PROFILE_START();
2 changes: 2 additions & 0 deletions easybuild/easyconfigs/o/OpenBLAS/OpenBLAS-0.3.18-GCC-11.2.0.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,13 @@ sources = ['v%(version)s.tar.gz']
patches = [
('large.tgz', '.'),
('timing.tgz', '.'),
'OpenBLAS-0.3.17_fix-segfault-ztrsv.patch',
]
checksums = [
'1632c1e8cca62d8bed064b37747e331a1796fc46f688626337362bf0d16aeadb', # v0.3.18.tar.gz
'f328d88b7fa97722f271d7d0cfea1c220e0f8e5ed5ff01d8ef1eb51d6f4243a1', # large.tgz
'999c65f8ea8bd4eac7f1c7f3463d4946917afd20a997807300fe35d70122f3af', # timing.tgz
'b1f89d90cc46b486534069135854e6081994b5a1a88370d32dae982e0f040111', # OpenBLAS-0.3.17_fix-segfault-ztrsv.patch
]

# extensive testing can be enabled by uncommenting the line below
Expand Down