-
Notifications
You must be signed in to change notification settings - Fork 304
New EasyBlock for ROCm-LLVM #3823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
42a7da6 to
51e9ad9
Compare
Zeldhoron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During testing this, when I was trying to build ROCm-LLVM, I added some small changes that fixed some issues for me.
Co-Authored-By: Bob Dröge <[email protected]>
Co-authored-by: Zeldhoron <[email protected]>
Co-authored-by: Zeldhoron <[email protected]>
111d016 to
51dfd8b
Compare
51dfd8b to
643e705
Compare
Signed-off-by: Jan André Reuter <[email protected]>
643e705 to
8e3ca37
Compare
|
First test report: |
Signed-off-by: Jan Andre Reuter <[email protected]>
d022852 to
d609070
Compare
|
@Thyre I was giving this another try with the easyconfig from easybuilders/easybuild-easyconfigs#23304, but I'm getting an error for Looks like that's because of the changes from #3875 (which uses I guess we either need to use a clean source dir for openmp, or disable the |
I ran into this with ROCm 7.0.0 in the first LLVM build and created #3937 to work around the issue for that. I didn't keep in mind that this also affects the second build, since the sources are patched at that point already. I think starting from a clean source is the best solution, since there might be other unexpected side-effects otherwise. I'll update the ROCm-LLVM EasyConfig PRs accordingly. |
|
@bedroge, I updated the ROCm-LLVM 6.4.1 PR to extract the sources again during |
Thanks, I'll do another build as well. |
(created using
eb --new-pr)Requires:
amdgcn-capabilitiesconfiguration option andamdgcn_capabilitieseasyconfig parameter + related templates, similar tocuda-compute-capabilitieseasybuild-framework#4860TODO:
LIBOMPTARGET_AMDGCN_GFXLISTThis PR introduces a separate EasyBlock for ROCm-LLVM, based on the heavy lifting of the LLVM EasyBlock. A few options need to be set differently, e.g. explicit disabling of #3747 due to the "generic" ROCm-LLVM interface not being compatible with the actual HSA being used in their OpenMP Tools Interface.
Lots of work has been done by @bedroge to get this EasyBlock working at all, thanks for that!