Skip to content

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented Feb 10, 2025

I totally misunderstood the purpose of the environment settings in the conda (#3562) and Anaconda (#3577) easyblocks. The goal is not to set some generic paths, but to unset linking paths to libraries in the conda environment.

The actual goal is avoiding that the conda environment is used by any other software external to it, neither at runtime or build time. Hence, this can logically be extended to include paths.

This PR replaces the default paths set by conda easyblock in module_load_environment with the deletion of those variables related to search paths for linking and includes that are unwanted in the conda module environment.

Depends on:

@lexming lexming changed the title fix module load environment in conda easyblock fix module load environment in conda and Anaconda easyblock Feb 10, 2025
@boegel boegel changed the title fix module load environment in conda and Anaconda easyblock fix module load environment in Anaconda and Conda easyblock Feb 12, 2025
@boegel boegel changed the title fix module load environment in Anaconda and Conda easyblock fix module load environment in Anaconda and Conda easyblocks Feb 12, 2025
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Feb 12, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS Anaconda3-2024.06-1.eb
  • SUCCESS Miniconda3-24.7.1-0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3506.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/f93178aa92299b2b06667e05743ab2c9 for a full test report.

@boegel boegel merged commit d2b6f70 into easybuilders:5.0.x Feb 12, 2025
19 checks passed
@lexming lexming deleted the fix-conda-modload-env branch February 13, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants