Skip to content

Set CMake hints for path to Python installation if it's direct or indirect dependency (when using CMake >= 3.12) #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Set CMake hints for path to Python installation if it's direct or indirect dependency (when using CMake >= 3.12) #3282

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a32295c
Set CMake hints for Python if added as a dependency
Flamefire Apr 5, 2024
72d224d
Remove blank line
Flamefire Apr 5, 2024
b7efb0b
Also handle indirect dependencies
Flamefire Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions easybuild/easyblocks/generic/cmakemake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,23 @@ def configure_step(self, srcdir=None, builddir=None):
options['BOOST_ROOT'] = boost_root
options['Boost_NO_SYSTEM_PATHS'] = 'ON'

# Make sure CMake finds our Python when it is a direct or indirect dependency
python_root = get_software_root('Python')
if python_root:
# CMake 3.12 introduced FindPython/FindPython2/FindPython3
# Below only FindPythonInterp existed in core CMake which don't has such hints.
# However PYTHON_EXECUTABLE could be used.
if LooseVersion(self.cmake_version) >= '3.12':
python_version = LooseVersion(get_software_version('Python'))
# For find_package(Python)
options['Python_ROOT_DIR'] = python_root
if python_version >= '3':
# For find_package(Python3)
options['Python3_ROOT_DIR'] = python_root
else:
# For find_package(Python2)
options['Python2_ROOT_DIR'] = python_root

if self.cfg.get('configure_cmd') == DEFAULT_CONFIGURE_CMD:
self.prepend_config_opts(options)
command = ' '.join([
Expand Down