-
Notifications
You must be signed in to change notification settings - Fork 303
handle templating correctly in CMakeMake when playing with configopts #2882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle templating correctly in CMakeMake when playing with configopts #2882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now but I was looking into another approach: Not modifying configopts at all: #2885
I noticed another issue with #2514: When iterating the values from a previous iteration will still be in configopts. So I see a much larger issue with the implementation of the iteration: Shouldn't the iterations be independent of each other? EasyBlocks may rightfully modify the self.cfg values to keep them across steps but that means the next iteration does not start with the same values as it should.
Until that is fixed in framework #2885 stops modifying configopts as it was the case before #2514
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
fixes #2881