Skip to content

Conversation

@mboisson
Copy link
Contributor

@mboisson mboisson commented Feb 8, 2023

fixes #2881

@mboisson mboisson changed the title handle templating correctly when playing with configopts handle templating correctly in CMakeMake when playing with configopts Feb 8, 2023
Copy link
Contributor

@Flamefire Flamefire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now but I was looking into another approach: Not modifying configopts at all: #2885

I noticed another issue with #2514: When iterating the values from a previous iteration will still be in configopts. So I see a much larger issue with the implementation of the iteration: Shouldn't the iterations be independent of each other? EasyBlocks may rightfully modify the self.cfg values to keep them across steps but that means the next iteration does not start with the same values as it should.

Until that is fixed in framework #2885 stops modifying configopts as it was the case before #2514

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Mar 15, 2023

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS MetaBAT-2.14-gompi-2019a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3170.skitty.os - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/0228bca735afebd25c801a3242cdb434 for a full test report.

@boegel boegel merged commit 1089a62 into easybuilders:develop Mar 15, 2023
@mboisson mboisson deleted the fix-cmake-templating branch March 15, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: Broken templating in EasyBuild 4.7.0

4 participants