Skip to content

redefine collect_exts_file_info instead of now deprecated fetch_extension_sources in OCaml easyblock #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2021
Merged

redefine collect_exts_file_info instead of now deprecated fetch_extension_sources in OCaml easyblock #2603

merged 1 commit into from
Oct 20, 2021

Conversation

@boegel
Copy link
Member

@boegel boegel commented Oct 16, 2021 •
edited
Loading

(created using eb --new-pr)

requires easybuilders/easybuild-framework#3860

@boegel boegel changed the title redefine collect_exts_file_info in OCaml easyblock, since fetch_extension_sources was deprecated in https://github.com/easybuilders/easybuild-framework/pull/3860 redefine collect_exts_file_info in OCaml easyblock Oct 16, 2021
@boegel boegel added the bug fix label Oct 16, 2021
@boegel boegel added this to the 4.5.0 (next release) milestone Oct 16, 2021
@boegel
Copy link
Member Author

boegel commented Oct 16, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OCaml-4.07.1-foss-2018b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2625.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/d90cbd25dd820c94822eb65b5f7799df for a full test report.

Micket
Micket approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit bcbe533 into easybuilders:develop Oct 20, 2021
@boegel boegel deleted the 20211016171247_new_pr_ocaml branch October 21, 2021 08:53
@boegel boegel changed the title redefine collect_exts_file_info in OCaml easyblock redefine collect_exts_file_info instead of now deprecated fetch_extension_sources in OCaml easyblock Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @Micket