-
Notifications
You must be signed in to change notification settings - Fork 303
add install_src option and enhance buildcmd option in PythonPackage easyblock #2534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allow to specify an explicit path (e.g. a whl file) for PythonPackage to be installed.
This allows to e.g. run a custom build script which builds a whl file which is then installed with pip.
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
|
@Flamefire Hmm, I ran into an easyconfig that's setting (see test report for |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
|
@boegel That is actually a good thing. The EC sets buildcmd but uses |
|
As far as I can tell using pip works fine, so the buildcmd should be removed: https://github.com/Theano/libgpuarray/blob/9cec61435c11cf2ffcf7c480c2d524772585c47f/doc/installation.rst |
Ah, that explains it, I was having trouble understand why the changes in this PR could cause trouble like that 😅 I'll look into fixing the |
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 11 out of 11 (11 easyconfigs in total) |
In e.g. easybuilders/easybuild-easyconfigs#13622 we need to run Bazel to generate a whl file and then install that using pip. This is currently unsupported by the PythonPackage easyblock.
This PR allows this by setting:
Also some minor moving around:
run_cmdinto one as external commands have a lot overhead