Skip to content

make easyblock for installing CMake aware of --sysroot #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2020
Merged

make easyblock for installing CMake aware of --sysroot #2187

merged 1 commit into from
Sep 25, 2020

Conversation

@boegel
Copy link
Member

@boegel boegel commented Sep 25, 2020 •
edited
Loading

(created using eb --new-pr)

This is required to ensure that zlib installed in the alternate system root indicated by --sysroot (cfr. easybuilders/easybuild-framework#3419) is found when building CMake.

It fixes the following issue when zlib in included in --filter-deps and no zlib is available in the host OS:

-- Using system-installed ZLIB
-- Could NOT find ZLIB (missing: ZLIB_INCLUDE_DIR)
CMake Error at CMakeLists.txt:426 (message):
  CMAKE_USE_SYSTEM_ZLIB is ON but a zlib is not found!

@boegel boegel added bug fix EESSI Related to EESSI project enhancement labels Sep 25, 2020
@boegel boegel added this to the next release (4.3.1) milestone Sep 25, 2020
akesandgren
akesandgren approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

akesandgren commented Sep 25, 2020

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 57c27f5 into easybuilders:develop Sep 25, 2020
@boegel boegel deleted the 20200925170051_new_pr_IkPTEVuUPg branch September 25, 2020 15:44
@boegel boegel mentioned this pull request Sep 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

bug fix EESSI Related to EESSI project enhancement

Projects

None yet

Milestone

4.3.1

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @akesandgren