Skip to content

Update Firecracker to v1.12.1 #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2025
Merged

Update Firecracker to v1.12.1 #944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a121930
Update Firecracker to 1.12.1
dobrac Aug 2, 2025
81ff07d
drop default fc version in db
dobrac Aug 4, 2025
a539e17
Regenerate schema
jakubno Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/build-sandbox-template/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ runs:
env:
TEMPLATE_ID: "2j6ly824owf4awgai1xo"
KERNEL_VERSION: "vmlinux-6.1.102"
FIRECRACKER_VERSION: "v1.10.1_1fcdaec"
FIRECRACKER_VERSION: "v1.12.1_d990331"
run: |
# Generate an unique build ID for the template for this run
export BUILD_ID=$(uuidgen)
Expand Down
13 changes: 13 additions & 0 deletions packages/db/migrations/20250802144312_update_firecracker_to_v1_12_1.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
-- +goose Up
-- +goose StatementBegin
-- Drop firecracker version default in env_builds table
ALTER TABLE "public"."env_builds"
ALTER COLUMN "firecracker_version" DROP DEFAULT;
-- +goose StatementEnd

-- +goose Down
-- +goose StatementBegin
-- Restore firecracker version default in env_builds table
ALTER TABLE "public"."env_builds"
ALTER COLUMN "firecracker_version" SET DEFAULT 'v1.10.1_1fcdaec';
-- +goose StatementEnd
3 changes: 2 additions & 1 deletion packages/fc-versions/firecracker_versions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
v1.5.0
8bb883111ff608dc2ca1a08d5e4eb2ddbd5c1c8b
v1.10.1
v1.10.1
v1.12.1
2 changes: 0 additions & 2 deletions packages/shared/pkg/models/envbuild/envbuild.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 0 additions & 12 deletions packages/shared/pkg/models/envbuild_create.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/shared/pkg/models/migrate/schema.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions packages/shared/pkg/models/runtime.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/shared/pkg/schema/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const (
DefaultKernelVersion = "vmlinux-6.1.102"
// The Firecracker version the last tag + the short SHA (so we can build our dev previews)
// TODO: The short tag here has only 7 characters — the one from our build pipeline will likely have exactly 8 so this will break.
DefaultFirecrackerVersion = "v1.10.1_1fcdaec"
DefaultFirecrackerVersion = "v1.12.1_d990331"
)

type EnvBuild struct {
Expand All @@ -41,7 +41,7 @@ func (EnvBuild) Fields() []ent.Field {
field.Int64("free_disk_size_mb"),
field.Int64("total_disk_size_mb").Optional().Nillable(),
field.String("kernel_version").Default(DefaultKernelVersion).SchemaType(map[string]string{dialect.Postgres: "text"}),
field.String("firecracker_version").Default(DefaultFirecrackerVersion).SchemaType(map[string]string{dialect.Postgres: "text"}),
field.String("firecracker_version").SchemaType(map[string]string{dialect.Postgres: "text"}),
field.String("envd_version").SchemaType(map[string]string{dialect.Postgres: "text"}).Nillable().Optional(),
field.String("cluster_node_id").SchemaType(map[string]string{dialect.Postgres: "text"}).Optional().Nillable(),
field.String("reason").SchemaType(map[string]string{dialect.Postgres: "text"}).Nillable().Optional(),
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/seed.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ func seed(db *db.DB, data SeedData) error {
SetFreeDiskSizeMB(512).
SetTotalDiskSizeMB(1982).
SetKernelVersion("vmlinux-6.1.102").
SetFirecrackerVersion("v1.10.1_1fcdaec").
SetFirecrackerVersion("v1.12.1_d990331").
SetEnvdVersion("0.2.4").
SetNillableCreatedAt(build.createdAt).Save(ctx)
if err != nil {
Expand Down
Loading