Ensure workdir exists before running a command #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobrac
force-pushed
the
when-workdir-is-deleted-recreate-it-e2b-2787
branch
from
65a2ed0 to
50dfdfe
Compare
jakubno
previously approved these changes
Jul 30, 2025
dobrac
force-pushed
the
when-workdir-is-deleted-recreate-it-e2b-2787
branch
from
50dfdfe to
c4debff
Compare
dobrac
dismissed
jakubno’s stale review
changed the approach from creating the dir to erroring out fast
dobrac
force-pushed
the
when-workdir-is-deleted-recreate-it-e2b-2787
branch
from
c4debff to
31b1ca2
Compare
dobrac
force-pushed
the
when-workdir-is-deleted-recreate-it-e2b-2787
branch
from
31b1ca2 to
9b38570
Compare
jakubno
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the working directory exists before executing any command. Running commands in a non-existent directory can cause unpredictable behavior, including silent failures, incorrect error messages, or commands executing in unexpected locations (such as the parent directory or system root).
This solution fails immediately when the directory doesn't exist to communicate the reason to the user. This a difference from how Dockerfile behaves, but keeps the behavior clear as it's a bit unexpected situation.