Skip to content

Increase envd timeout #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2025
Merged

Increase envd timeout #926

merged 3 commits into from
Jul 29, 2025

Conversation

djeebus
Copy link
Contributor

@djeebus djeebus commented Jul 28, 2025

This timeout is used when waiting for the sandbox to become healthy. Before this point, there are parts of the process where things should fail quickly. At this point, however, we're waiting for customer-provided code to become healthy, and we don't control this duration. Let's give them as much time as we can, while still providing some room for a retry if it takes too long. The client SDK defaults to a 60 second timeout, so 40 seconds gives them enough time to try twice, although the second attempt won't have as long as the first to complete successfully.

@djeebus djeebus marked this pull request as ready for review July 28, 2025 23:16
@djeebus djeebus added the bug Something isn't working label Jul 29, 2025
@djeebus djeebus self-assigned this Jul 29, 2025
@jakubno
Copy link
Member

jakubno commented Jul 29, 2025

Should we think about making this a feature flag so we can change it on the fly without redeployment? wdyt?

@djeebus
Copy link
Contributor Author

djeebus commented Jul 29, 2025

This is the first time (to my knowledge) that we're modifying this. I suspect it's not worth the effort, given how rarely it's going to be modified, but if we want to start tuning at some point, it'd be worth updating it then.

@jakubno
Copy link
Member

jakubno commented Jul 29, 2025

I see this more as a guess; maybe we'll find out that after 20 seconds, it never succeeds. Also, if the main issue isn't time, it's possible that the success rate could be lower than the current solution. In those cases, we won't be able to reduce the timeout without redeploying.

@djeebus
Copy link
Contributor Author

djeebus commented Jul 29, 2025

I see this more as a guess; maybe we'll find out that after 20 seconds, it never succeeds. Also, if the main issue isn't time, it's possible that the success rate could be lower than the current solution. In those cases, we won't be able to reduce the timeout without redeploying.

@ValentaTomas has some evidence that the sandbox in question would succeed after ~30-35 seconds. I agree that it's still a guess though. This feels more like a drive-by tweak; if we focus on it, agree we should invest.

@djeebus djeebus merged commit cbe00b1 into main Jul 29, 2025
25 checks passed
@djeebus djeebus deleted the change-env-vars branch July 29, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants