Skip to content

error="" behaviour + readOnly cursor #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2022
Merged

error="" behaviour + readOnly cursor #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...-cdk-site/src/app/pages/theme-builder/previews/radio-preview/radio-preview.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@
<dxc-radio-group
[options]="options"
label="readOnly radio"
error="error message"
error=""
></dxc-radio-group>
<dxc-radio-group
[options]="options"
label="readOnly radio"
error="Error message"
></dxc-radio-group>
</tbuilder-component-mode>
<tbuilder-component-mode text="Default">
Expand Down
2 changes: 1 addition & 1 deletion projects/dxc-ngx-cdk/src/lib/dxc-radio-group/dxc-radio-group.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@
</ng-container>
</div>
<input #inputRef class="valueInput" [name]="name" [value]="value" readOnly aria-hidden="true" />
<span *ngIf="error" class="errorMessage">{{ error }}</span>
<span *ngIf="error || error===''" class="errorMessage">{{ error }}</span>
1 change: 1 addition & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-radio-group/dxc-radio-group.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ export class DxcRadioGroupComponent implements OnInit {
font-weight: var(--radioGroup-errorMessageFontWeight);
line-height: var(--radioGroup-errorMessageLineHeight);
font-family: var(--radioGroup-labelFontFamily);
height: var(--radioGroup-errorMessageLineHeight);
}
.valueInput {
display: none;
Expand Down
2 changes: 1 addition & 1 deletion projects/dxc-ngx-cdk/src/lib/dxc-radio-group/dxc-radio/dxc-radio.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export class DxcRadioGroupItemComponent implements OnInit {
return css`
display: inline-flex;
align-items: center;
${inputs.disabled ? "pointer-events: none" : "cursor: pointer"};
${inputs.disabled ? "pointer-events: none" : inputs.readOnlyState ? "cursor: default" : "cursor: pointer"};
width: fit-content;
.radioInputContainer {
display: flex;
Expand Down