Skip to content

Types for Header component #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2022
Merged

Types for Header component #662

merged 3 commits into from
Feb 2, 2022

Conversation

@marcialfps
Copy link
Collaborator

@marcialfps marcialfps commented Feb 1, 2022

Closes #639

Changes

  • Header and Dropdown header types.
  • Documentation:
    • underlined default value change to false.
    • Add logoResponsiveSrc prop.
    • Description fixes.
  • DxcHeaderDropdown working with Dropdown props.

@Jialecl Jialecl merged commit ed0a4d7 into master Feb 2, 2022
@Jialecl Jialecl deleted the marcialfps-header-types branch February 2, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jialecl Jialecl Jialecl approved these changes

+1 more reviewer

@aidamag aidamag aidamag approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add types for Header component

4 participants

@marcialfps @Jialecl @aidamag