Skip to content

Conversation

@sohwak
Copy link
Contributor

@sohwak sohwak commented Jun 19, 2023

Brief comments on the purpose of your changes:

For Dune Engine V2

  • Removed the filter on fee_wallet and right_hash, which were previously filtered to get the OS.

I've checked that:

General checks:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased
  • if adding a new model, I edited the dbt project YAML file with new directory path for both models and seeds (if applicable)
  • if wanting to expose a model in the UI (Dune data explorer), I added a post-hook in the JINJA config to add metadata (blockchains, sector/project, name and contributor Dune usernames)

Pricing checks:

  • coin_id represents the ID of the coin on coinpaprika.com
  • all the coins are active on coinpaprika.com (please remove inactive ones)

Join logic:

  • if joining to base table (i.e. ethereum transactions or traces), I looked to make it an inner join if possible

Incremental logic:

  • I used is_incremental & not is_incremental jinja block filters on both base tables and decoded tables
    • where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to base table (i.e. ethereum transactions or traces), I applied join condition where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to prices view, I applied join condition where minute >= date_trunc("day", now() - interval '1 week')

@dune-eng
Copy link

Workflow run id 5314286742 approved.

@dune-eng
Copy link

Workflow run id 5314286734 approved.

@dune-eng
Copy link

Workflow run id 5314340291 approved.

@dune-eng
Copy link

Workflow run id 5314340290 approved.

@dune-eng
Copy link

Workflow run id 5317659151 approved.

@dune-eng
Copy link

Workflow run id 5317659144 approved.

@dune-eng
Copy link

Workflow run id 5318188484 approved.

@dune-eng
Copy link

Workflow run id 5318188478 approved.

@dune-eng
Copy link

Workflow run id 5318247587 approved.

@dune-eng
Copy link

Workflow run id 5318247588 approved.

@0xRobin 0xRobin added ready-for-merging dbt: nft covers the NFT dbt subproject labels Jun 20, 2023
@jeff-dude jeff-dude merged commit c3e159e into duneanalytics:main Jun 20, 2023
olgafetisova pushed a commit to olgafetisova/spellbook that referenced this pull request Nov 14, 2023
)

* fix opensea-v3-polygon to include OS trades

* rerun

* rerun

* rerun

* rerun

* rerun

---------

Co-authored-by: jeff-dude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dbt: nft covers the NFT dbt subproject ready-for-merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants