Skip to content
This repository was archived by the owner on Jan 10, 2019. It is now read-only.

Conversation

@talsraviv
Copy link
Contributor

No description provided.

@talsraviv talsraviv changed the title New re-org overhaul first commit Docs Simplification Oct 15, 2015
@talsraviv
Copy link
Contributor Author

@zekiel @moollaza @russellholt in preparation for tomorrow

What's left in order of priority - correct me otherwise:

  • First Goodie walkthrough
  • Screenshots
  • Linking
  • Index, Prev/Next
  • Two more walkthroughs each for Spice, Goodie, and Cheat Sheets
  • Submission Checklist (@moollaza)

Questions:

Random:

@russellholt
Copy link
Contributor

@talsraviv You're seeing the fact that goodies and spice are slowly converging. most of the JS stuff applies to both. The global object Spice is really an alias to the global object DDH. so Spice.add() should really be DDH.add(). The main divergence is the interface, which isn't going to be addressed until the next generation of the api. for a spice that's currently the ddg_spice_* function that calls DDH.add() (formerly Spice.add), whereas for a goodie that's the DDH.X.build function which returns an object. The argument to DDH.add() for a spice, and the object returned by build for a goodie have the same format.

  • Pure JS functions: somewhat relevant, but no - it's been taken over by goodies
  • Spice JS API: yes, available to goodies.
  • other dev environments - maybe some of that can be moved to a README.md, maybe in duckpan? I think we still need some of that but I imagine it could be reduced. It's kind of wordy. Maybe:
    • reduce Operating System notes to list the ones it's been installed on and for everything else YMMV
    • installing duckpan locally: cut out all the examples
    • shell completion: just the para + the links. So wordy; up to you.
    • the rest just goes on and on and on and on.. do we need that much detail? It's written for newbies but newbies should be using codio.
  • Spice Advanced Frontend : yes, there must be a better way, but it should remain documented for now.

@talsraviv
Copy link
Contributor Author

@zekiel @moollaza as far as submitting section the pages are:

  • Intro/Quality
  • Checklist
  • Maintenance
  • Pull request instructions

screen shot 2015-10-16 at 10 49 45 am

We'll discuss what's most important for each to contain on the call today with @russellholt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"fronted" should be "frontend"

@talsraviv
Copy link
Contributor Author

@russellholt @moollaza check out the last commit if you can - I want to make sure I got it right especially on the DDG/DDH/Spice namespaces.

@talsraviv
Copy link
Contributor Author

@Eelviny @moollaza last commit incorporates your latest feedback - thanks!

@talsraviv
Copy link
Contributor Author

@moollaza @zekiel just pushed up the submission section - take a look. I used Zaahir's checklist and tried to keep it as straightforward and focused as I could. I divided it into what I thought should be explicit and what I will work into the rest of the docs.

@talsraviv
Copy link
Contributor Author

@moollaza btw the current docs mention checking for possibility of XSS - is that still relevant?

@talsraviv
Copy link
Contributor Author

(In the meantime I'm also reviewing asana/github issues to keep this branch updated with suggestions, seems good for now)

@moollaza
Copy link
Member

@moollaza btw the current docs mention checking for possibility of XSS - is that still relevant?

Yes, I just plugged an XSS issue this week. It's still required for the simple structured_answer in Goodies, and certainly possible in Spice's when using custom templates

@talsraviv
Copy link
Contributor Author

Just a note: I've been making all changes in a temporary repo on my account to be able to stage it on gitbooks without changing the main docs: https://github.com/talsraviv/duckduckgo-documentation-gitbook

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants