Re-enable clippy after upstream crash fix #932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error: this `if` has identical blocks
--> gen/build/src/gen/write.rs:704:33
|
704 | if arg.ty == RustString {
| _________________________________^
705 | | write!(out, "const ");
706 | | } else if let Type::RustVec(_) = arg.ty {
| |_________^
|
= note: `-D clippy::if-same-then-else` implied by `-D clippy::all`
note: same as this
--> gen/build/src/gen/write.rs:706:49
|
706 | } else if let Type::RustVec(_) = arg.ty {
| _________________________________________________^
707 | | write!(out, "const ");
708 | | }
| |_________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
error: this `if` has identical blocks
--> macro/src/expand.rs:430:33
|
430 | if arg.ty == RustString {
| _________________________________^
431 | | quote!(#var #colon *const #ty)
432 | | } else if let Type::RustVec(_) = arg.ty {
| |_________^
|
= note: `-D clippy::if-same-then-else` implied by `-D clippy::all`
note: same as this
--> macro/src/expand.rs:432:49
|
432 | } else if let Type::RustVec(_) = arg.ty {
| _________________________________________________^
433 | | quote!(#var #colon *const #ty)
434 | | } else if let Type::Fn(_) = arg.ty {
| |_________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
warning: lint `clippy::filter_map` has been removed: this lint has been replaced by `manual_filter_map`, a more specific lint
--> macro/src/lib.rs:6:5
|
6 | clippy::filter_map,
| ^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(renamed_and_removed_lints)]` on by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Clippy crash that caused us to disable it (rust-lang/rust-clippy#7423) was fixed in rust-lang/rust-clippy#7428 + rust-lang/rust#87152 in nightly-2021-07-16.