update(getPackageResolution) take in to account non-standard versioning on Yarn lockfiles #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng on Yarn lockfiles
|
How do I use this pull request to fix react-scripts in my Create React App project ? |
|
Hi, thanks for the contribution! ❤️ Sorry it too me so long to get around to this. There was a fix for this in #213 so I took that one, but I appreciate the help nonetheless 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages tend to use non-standard versioning in their package.json files (e.g. commit hashes in the case of [email protected]+3d74b79d).
Currently, manually installing
[email protected]+3d74b79dand then runningyarn patch-package react-scriptswill result in the errorCan't find lockfile entry for react-scripts. This change should fix this issue.