Improve fault tolerance by handling leadership election and other metadata changes #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Any feedback is welcomed - however, please don't close this until the integration test suite is ready. |
Collaborator
Contributor
Author
|
Just did a rebase - tests appear to be passing. Working on additional tests now. (oops - I think GitHub deleted @mrtheb's comments.) |
Collaborator
Contributor
Author
|
Yes, I am working on that right now. I will also make some of the changes recommended by @mrtheb. |
Collaborator
|
I had opened a ticket for something similar - #40 |
Contributor
Author
|
hello travis ... knock knock |
Collaborator
|
@jimjh I'm guessing it's not building automatically since the PR can't be merged automatically. Try rebasing |
…, failed_messages - add integration tests for sync producer - add integration tests for async producer w. leadership election - use log.exception
Contributor
Author
|
How does this look? |
mumrah
added a commit
that referenced
this pull request
Oct 7, 2013
Improve fault tolerance by handling leadership election and other metadata changes Thanks, @jimjh!
Contributor
Author
|
OH YEAH. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside
client.pysendfails insidebroker_aware, resettopics_to_brokersFailedPayloadsExceptionInside
conn.pysendorrecvfails, set adirtyflagsend, if thedirtyflag is set, reinit connection