[release/6.0-rc1] Accessibility: Fix ClickablePoint property when IsOffscreen is true #5130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
SamBent
approved these changes
Aug 20, 2021
|
Approved by Tactics via email. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #4631
Description
The automation ClickablePoint property shouldn't be an onscreen point, when the IsOffscreen property is true.
This is a port of @SamBent's Accessibility fix from main.
Customer Impact
Accessibility Insights for Windows flags this as an accessibility error.
Regression
Testing
The test cases that claimed to check this didn't work, for 3 independent reasons. I've repaired them in a companion PR in the test repo. That PR is much more interesting than this one.
Risk
Low. Changing this case to conform to the expected behavior, per UIA docs. The new return value is the same as we return in other "no clickable point" scenarios.