Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 16, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: d9f5b309-084f-43b5-02de-08d8b80548e4
  • Build: 20240616.2
  • Date Produced: June 16, 2024 10:29:34 PM UTC
  • Commit: f4fd3ea470aeef5a7c843e9fd5fa1ce50b6b5b70
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow

…0615.5

Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.ComponentModel.Composition , System.ComponentModel.Composition.Registration , System.Configuration.ConfigurationManager , System.Data.Odbc , System.Data.OleDb , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.DirectoryServices.AccountManagement , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Packaging , System.IO.Ports , System.Management , System.Reflection.Context , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceModel.Syndication , System.ServiceProcess.ServiceController , System.Speech , System.Text.Encoding.CodePages , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0
 From Version 9.0.0-preview.6.24307.2 -> To Version 9.0.0-preview.6.24315.5
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner June 16, 2024 12:00
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

…0616.2

Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.ComponentModel.Composition , System.ComponentModel.Composition.Registration , System.Configuration.ConfigurationManager , System.Data.Odbc , System.Data.OleDb , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.DirectoryServices.AccountManagement , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Packaging , System.IO.Ports , System.Management , System.Reflection.Context , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceModel.Syndication , System.ServiceProcess.ServiceController , System.Speech , System.Text.Encoding.CodePages , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0
 From Version 9.0.0-preview.6.24307.2 -> To Version 9.0.0-preview.6.24316.2
@lonitra
Copy link
Member

lonitra commented Jun 17, 2024

Error:

Unable to find directory for cmake 3.21.0; please make sure the tool is installed on this image.

@directhex we are starting to get some build failures after switching to cmake 3.21.0. It looks like some CI machines do not have that version installed. Any recommendations for what to do here? Should we revert back to latest?

@lonitra
Copy link
Member

lonitra commented Jun 17, 2024

For now, I have reverted cmake to "latest" to unblock dependency flow, but we should determine best next steps if we should not be using latest

@directhex
Copy link
Contributor

directhex commented Jun 17, 2024 via email

@codecov
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.41984%. Comparing base (79472b4) to head (26546b2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11540         +/-   ##
===================================================
+ Coverage   74.41004%   74.41984%   +0.00979%     
===================================================
  Files           3032        3032                 
  Lines         628262      628874        +612     
  Branches       46817       46847         +30     
===================================================
+ Hits          467490      468007        +517     
- Misses        157420      157519         +99     
+ Partials        3352        3348          -4     
Flag Coverage Δ
Debug 74.41984% <ø> (+0.00979%) ⬆️
integration 17.90298% <ø> (-0.08683%) ⬇️
production 47.22458% <ø> (-0.03157%) ⬇️
test 96.96975% <ø> (+0.00395%) ⬆️
unit 44.26886% <ø> (+0.03192%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lonitra lonitra merged commit 0b65434 into main Jun 17, 2024
@lonitra lonitra deleted the darc-main-e370b960-68d9-46f5-b40a-88bf4835efee branch June 17, 2024 21:44
@kasperk81
Copy link
Contributor

@lonitra did you see #11542?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants