Code cleanup only and Add VB Tests

[paul1956]

Fixes part of #10090
Standalone PR to do some cleanup of VB Code
Removes VB Option from source files and moves to Project File
Correct Spelling and Capitalization Errors
Add a few tests
Update editorConfig to support converting 3 NotInheritable classes to Modules.
Add a few tests
Change format of XLM Comment to indent text by 1 space
Change a few Private functions to Friend for testing
Not all issues are addressed in files I expect to replace.
Not done is reorganizing code in files to be in standard order, this will be a follow-on PR

Proposed changes

Fix above with very minimal code changes

Customer Impact

• None only developers will notice

Regression?

No

Risk

• Minimal due to almost no code changes

Test methodology

Added tests where required otherwise covered by existing tests

Visual Basic only

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Attention: Patch coverage is 88.18824% with 251 lines in your changes missing coverage. Please review.

Project coverage is 74.76345%. Comparing base (88d7659) to head (54ea3f5).
Report is 1 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #11215         +/-   ##
===================================================
+ Coverage   74.57429%   74.76345%   +0.18916%     
===================================================
  Files           3041        3056         +15     
  Lines         629823      631485       +1662     
  Branches       46846       46877         +31     
===================================================
+ Hits          469686      472120       +2434     
+ Misses        156783      155997        -786     
- Partials        3354        3368         +14     

Flag	Coverage Δ
Debug	74.76345% <88.18824%> (+0.18916%)	⬆️
integration	17.96623% <14.77273%> (+0.08492%)	⬆️
production	47.77523% <62.27273%> (+0.30010%)	⬆️
test	96.96834% <94.95549%> (-0.01002%)	⬇️
unit	44.83671% <52.04545%> (+0.27165%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[paul1956]

@KlausLoeffelmann can you get someone assigned to review please. This consolidates much of the cleanup and adds testing to VB code. Some files are not touched as they require code changes covered in other PR's.

[elachlan]

when you are merging master, are you rebasing? There are a few files that have changed in the PR which are irrelevant to the actual PR. global.json, Version.props, Version.Details.xml.

[paul1956]

when you are merging master, are you rebasing? There are a few files that have changed in the PR which are irrelevant to the actual PR. global.json, Version.props, Version.Details.xml.

That was an error, I thought I reverted the 2 commits. I could not find any way to cancel the commits accidentally to main.
Web to the rescue and I was able to undo the merge into master,

@elachlan please let me know if there are still issues with Main/master. All my changes should only be to my PR.

[elachlan]

In visual basic the namespace is made up of the rootnamespace in the project file plus the namespace inside the file.

[paul1956]

In visual basic the namespace is made up of the rootnamespace in the project file plus the namespace inside the file.

Yes I was actually at Master where it’s incorrect. VS was slow in updating Test Explorer when I switched branches.

[paul1956]

@lonitra @KlausLoeffelmann
I am going to break this PR into very small parts to simplify review and merge. #11653 is the first with just 3 files changed.

[elachlan]

@paul1956 I am not on the winforms team (or with microsoft/dotnet), so I have no control over when stuff is reviewed or merged.

I'd say it would be easier to split this PR into smaller PRs. Can the test changes be moved to their own PR?

The project template changes can be done in a small PR that would probably be merged immediately.

Are the .gitattributes changes on purpose? That looks like it reverts changes that were made in a PR recently.

[paul1956]

@elachlan I created PR #11653 which is the first part of this larger PR. I will break it down in multiple parts to simplify review.
Thanks for the feedback

[paul1956]

@lonitra @KlausLoeffelmann Everything in here has been merger into Main or #11655 so I am closing