Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,14 @@ dotnet_code_quality.ca1822.api_surface = private, internal
dotnet_code_quality.ca2208.api_surface = public
dotnet_diagnostic.CS1591.severity = suggestion
dotnet_analyzer_diagnostic.category-Style.severity = warning
#Name can be simplified
dotnet_diagnostic.IDE0002.severity = suggestion
#Use explicit type instead of var
dotnet_diagnostic.IDE0008.severity = suggestion
#Add missing cases to switch statement
dotnet_diagnostic.IDE0010.severity = suggestion
#Simplify LINQ expression
dotnet_diagnostic.IDE0120.severity = suggestion
#Use expression body for constructors
dotnet_diagnostic.IDE0021.severity = suggestion
#Use expression body for methods
Expand All @@ -200,6 +204,10 @@ dotnet_diagnostic.IDE0028.severity = suggestion
dotnet_diagnostic.IDE0032.severity = suggestion
#Use conditional expression for return
dotnet_diagnostic.IDE0046.severity = suggestion
#Remove unused private member
dotnet_diagnostic.IDE0051.severity = suggestion
#Remove unread private member
dotnet_diagnostic.IDE0052.severity = suggestion
#Remove unnecessary expression value
dotnet_diagnostic.IDE0058.severity = suggestion
#Add missing cases to switch expression
Expand All @@ -220,6 +228,10 @@ dotnet_diagnostic.IDE0300.severity = suggestion
dotnet_diagnostic.IDE0301.severity = suggestion
#Collection initialization can be simplified
dotnet_diagnostic.IDE0305.severity = suggestion
#Simplify collection initialization
dotnet_diagnostic.IDE0306.severity = suggestion
#Lambda expression can be simplified
dotnet_diagnostic.IDE0350.severity = suggestion

# License header
file_header_template = Licensed to the .NET Foundation under one or more agreements.\nThe .NET Foundation licenses this file to you under the MIT license.
Expand All @@ -229,6 +241,9 @@ file_header_template = Licensed to the .NET Foundation under one or more agreeme
# Ensure minimum API surface is respected
dotnet_diagnostic.BCL0001.severity = warning

# Don't require explicit access modifiers for interface members (conflicts with IDE0040)
dotnet_diagnostic.SA1400.severity = none

# AppContext default value expected to be true
dotnet_diagnostic.BCL0010.severity = warning

Expand Down
2 changes: 1 addition & 1 deletion eng/Versions.props
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project>
<PropertyGroup>
<VersionPrefix>9.0.306</VersionPrefix>
<VersionPrefix>9.0.307</VersionPrefix>
<!-- When StabilizePackageVersion is set to 'true', this branch will produce stable outputs for 'Shipping' packages -->
<StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">true</StabilizePackageVersion>
<DotNetFinalVersionKind Condition="'$(StabilizePackageVersion)' == 'true'">release</DotNetFinalVersionKind>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@ public interface IBindSymbolSource : IPrioritizedComponent
/// <summary>
/// The user friendly name of the component.
/// </summary>
public string DisplayName { get; }
string DisplayName { get; }

/// <summary>
/// Prefix that is used in binding to reference the component.
/// </summary>
public string? SourcePrefix { get; }
string? SourcePrefix { get; }

/// <summary>
/// If set to true, the component required exact prefix match to be used.
/// </summary>
public bool RequiresPrefixMatch { get; }
bool RequiresPrefixMatch { get; }

/// <summary>
/// Gets the value corresponding to <paramref name="bindName"/>.
Expand All @@ -31,6 +31,6 @@ public interface IBindSymbolSource : IPrioritizedComponent
/// <param name="bindName">the value to retrieve (without prefix).</param>
/// <param name="cancellationToken">cancellation token.</param>
/// <returns></returns>
public Task<string?> GetBoundValueAsync(IEngineEnvironmentSettings settings, string bindName, CancellationToken cancellationToken);
Task<string?> GetBoundValueAsync(IEngineEnvironmentSettings settings, string bindName, CancellationToken cancellationToken);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ public interface ISdkInfoProvider : IIdentifiedComponent
/// </summary>
/// <param name="cancellationToken"></param>
/// <returns>SDK version.</returns>
public Task<string> GetCurrentVersionAsync(CancellationToken cancellationToken);
Task<string> GetCurrentVersionAsync(CancellationToken cancellationToken);

/// <summary>
/// All installed SDK installations semver version strings.
/// </summary>
/// <param name="cancellationToken"></param>
/// <returns>SDK version strings.</returns>
public Task<IEnumerable<string>> GetInstalledVersionsAsync(CancellationToken cancellationToken);
Task<IEnumerable<string>> GetInstalledVersionsAsync(CancellationToken cancellationToken);

/// <summary>
/// Provides localized suggestion on action to be taken so that constraints requiring specified workloads can be met.
Expand All @@ -31,6 +31,6 @@ public interface ISdkInfoProvider : IIdentifiedComponent
/// <param name="supportedVersions">SDK versions required by a constraint (in an 'OR' relationship).</param>
/// <param name="viableInstalledVersions">SDK versions installed, that can meet the constraint - instructions should be provided to switch to any of those.</param>
/// <returns>Localized string with remedy suggestion specific to current host.</returns>
public string ProvideConstraintRemedySuggestion(IReadOnlyList<string> supportedVersions, IReadOnlyList<string> viableInstalledVersions);
string ProvideConstraintRemedySuggestion(IReadOnlyList<string> supportedVersions, IReadOnlyList<string> viableInstalledVersions);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public interface IWorkloadsInfoProvider : IIdentifiedComponent
/// </summary>
/// <param name="token"></param>
/// <returns>Set of installed workloads.</returns>
public Task<IEnumerable<WorkloadInfo>> GetInstalledWorkloadsAsync(CancellationToken token);
Task<IEnumerable<WorkloadInfo>> GetInstalledWorkloadsAsync(CancellationToken token);

/// <summary>
/// Provides localized suggestion on action to be taken so that constraints requiring specified workloads can be met.
Expand All @@ -23,6 +23,6 @@ public interface IWorkloadsInfoProvider : IIdentifiedComponent
/// </summary>
/// <param name="supportedWorkloads">Workloads required by a constraint (in an 'OR' relationship).</param>
/// <returns>Localized string with remedy suggestion specific to current host.</returns>
public string ProvideConstraintRemedySuggestion(IReadOnlyList<string> supportedWorkloads);
string ProvideConstraintRemedySuggestion(IReadOnlyList<string> supportedWorkloads);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public interface IValidationEntry
/// <summary>
/// Error severity.
/// </summary>
public enum SeverityLevel
enum SeverityLevel
{
None,
Info,
Expand Down Expand Up @@ -42,7 +42,7 @@ public enum SeverityLevel
/// <summary>
/// Details of the error location.
/// </summary>
public readonly struct ErrorLocation
readonly struct ErrorLocation
{
/// <summary>
/// Gets the filename where the error occurred.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,40 +11,40 @@ public interface ITemplatePackageInfo
/// <summary>
/// Gets template package name.
/// </summary>
public string Name { get; }
string Name { get; }

/// <summary>
/// Gets template package version.
/// </summary>
public string? Version { get; }
string? Version { get; }

/// <summary>
/// Gets total number of downloads for the package.
/// Optional, might be 0 in case search provider cannot provide number of downloads.
/// </summary>
public long TotalDownloads { get; }
long TotalDownloads { get; }

/// <summary>
/// Gets the list of template package owners.
/// </summary>
public IReadOnlyList<string> Owners { get; }
IReadOnlyList<string> Owners { get; }

/// <summary>
/// Gets the indication if the package is verified.
/// </summary>
/// <remarks>
/// For NuGet.org 'verified' means that package ID is under reserved namespaces, see <see href="https://docs.microsoft.com/en-us/nuget/nuget-org/id-prefix-reservation"/>.
/// </remarks>
public bool Reserved { get; }
bool Reserved { get; }

/// <summary>
/// Gets the NuGet package description.
/// </summary>
public string? Description { get; }
string? Description { get; }

/// <summary>
/// Gets the URL to the package icon.
/// </summary>
public string? IconUrl { get; }
string? IconUrl { get; }
}
}