Update dependencies from Arcade, update TFMs and remove .NETStandard1.x dependencies #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmat can you please take a look? |
ViktorHofer
force-pushed
the
ModernizeSymreaderRepo
branch
from
e8b947b to
01289cb
Compare
|
@tmat rebased on top of latest main. Can you please take a look? |
tmat
approved these changes
May 3, 2023
|
Looks great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are grouped into commits:
As mentioned in Clean-up sourcelink repo and remove workarounds sourcelink#1003 (comment), these aren't required by tooling anymore.
MSBuild license headers are only required in package props/targets msbuild files that ship to another repository.
The System.ValueTuple package dependency wasn't required. The System.Collections.Immutable package dependency is only required on .NET Framework as the library is inbox on .NETCoreApp. The System.Reflection.Metadata dependency wasn't required either when multi-targeting instead of targeting netstandard2.0 only.
Enable Arcade's
FlagNetStandard1XDependenciesswitch to verify that .NET Standard 1.x dependencies (which are problematic because of graph size and vulnerable nodes) aren't (transitively) referenced. Upgrade the NETStandard.Library brought in by xunit to 2.0.3 which avoids the .NETStandard1.x dependency graph.Two other commits were cherry-picked into a14ebad