Clean-up sourcelink repo and remove workarounds (grouped into commits) #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
force-pushed
the
SourceBuildCleanupInCommits
branch
from
963da85 to
c362d91
Compare
I verified that this is no longer needed. Sourcebuild automatically creates packages.
Delete runtimeconfig.template.json in favor of the in-built "<RollForward>...</RollForward>" switch.
Use the Microsoft.Build.NoTargets SDK for content-only packages. That avoids invoking the compiler without defining custom targets and makes the repository use the same path as other repositories in the stack.
Projects that offer a .NETFramework TFM only are already automatically removed by arcade's TFM filtering that is enabled for source-build.
ViktorHofer
force-pushed
the
SourceBuildCleanupInCommits
branch
from
c362d91 to
be7ddc1
Compare
Member
Author
|
Resolved the merge conflict. cc @tmat |
tmat
reviewed
Apr 28, 2023
tmat
reviewed
Apr 28, 2023
src/Microsoft.Build.Tasks.Git.UnitTests/Microsoft.Build.Tasks.Git.UnitTests.csproj
Outdated
Show resolved
Hide resolved
tmat
approved these changes
May 3, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1003
Grouped into commits
I will send separate PRs after this one is in for the formatting changes and updating the TFM to use
$(NetFrameworkToolCurrent)(which requires a new Arcade update).