Add sbrp package for System.Text.Encoding.CodePages 6.0.0 #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaMilosavljevic
requested review from
MichaelSimons,
mthalman and
oleksandr-didyk
as code owners
oleksandr-didyk
approved these changes
Mar 29, 2023
Contributor
|
Just a quick side question - shouldn't the added package be mentioned in dotnet/source-build#2357? |
mthalman
reviewed
Mar 29, 2023
eng/Build.props
Outdated
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Text.Encodings.Web.6.0.0.csproj" /> | ||
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Text.Json.6.0.0.csproj" /> | ||
|
|
||
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Memory.4.5.4.csproj" /> |
Member
There was a problem hiding this comment.
This shouldn't be needed since this package is already included.
Member
Author
There was a problem hiding this comment.
Thanks! Right - forgot to remove System.Memory entry - will update this.
MichaelSimons
approved these changes
Mar 29, 2023
mthalman
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Package is required by
razorper-repo prebuilt work - dotnet/razor#8492