Skip to content

Conversation

@jjonescz
Copy link
Member

@jjonescz jjonescz commented Jul 7, 2025

Based on reverting dotnet/source-build-externals#467.

@jjonescz jjonescz marked this pull request as ready for review July 7, 2025 12:17
@jjonescz jjonescz requested a review from a team as a code owner July 7, 2025 12:17
@MichaelSimons
Copy link
Member

@jjonescz, can you confirm the consumption of this dependency is something that will be completed for .NET 10? TIA

@jjonescz
Copy link
Member Author

jjonescz commented Jul 7, 2025

Yes, once this is available, I will replace interactivity implemented manually in the sdk with the library. That's only for a couple for interactive prompts in dotnet tool execute and dotnet project convert currently (dotnet/sdk#49660).

@MichaelSimons MichaelSimons merged commit 2b4409f into dotnet:main Jul 7, 2025
4 checks passed
@jjonescz jjonescz deleted the spectre branch July 7, 2025 12:38
@MichaelSimons
Copy link
Member

MichaelSimons commented Jul 7, 2025

@jjonescz - this appears to have caused a build failing in the flow to the VMR. Can you take a look? TIA.

Failure

    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(335,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error : Unhandled exception. Interop+Crypto+OpenSslCryptographicException: error:03000098:digital envelope routines::invalid digest [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Interop.Crypto.RsaSignHash(SafeEvpPKeyHandle pkey, RSASignaturePaddingMode paddingMode, HashAlgorithmName digestAlgorithm, ReadOnlySpan`1 hash, Span`1 destination) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at System.Security.Cryptography.RSAOpenSsl.SignHash(Byte[] hash, HashAlgorithmName hashAlgorithm, RSASignaturePadding padding) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.SigningUtilities.CalculateRsaSignature(IEnumerable`1 content, RSAParameters privateKey) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.DesktopStrongNameProvider.<>c__DisplayClass12_0.<SignBuilder>b__0(IEnumerable`1 content) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at System.Reflection.PortableExecutable.PEBuilder.Sign(BlobBuilder peImage, Blob strongNameSignatureFixup, Func`2 signatureProvider) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.Cci.PeWriter.WritePeToStream(EmitContext context, CommonMessageProvider messageProvider, Func`1 getPeStream, Func`1 getPortablePdbStreamOpt, PdbWriter nativePdbWriterOpt, String pdbPathOpt, Boolean metadataOnly, Boolean isDeterministic, Boolean emitTestCoverageData, Nullable`1 privateKeyOpt, CancellationToken cancellationToken) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.Compilation.SerializePeToStream(CommonPEModuleBuilder moduleBeingBuilt, DiagnosticBag metadataDiagnostics, CommonMessageProvider messageProvider, Func`1 getPeStream, Func`1 getMetadataPeStreamOpt, Func`1 getPortablePdbStreamOpt, PdbWriter nativePdbWriterOpt, String pdbPathOpt, RebuildData rebuildData, Boolean metadataOnly, Boolean includePrivateMembers, Boolean isDeterministic, Boolean emitTestCoverageData, Nullable`1 privateKeyOpt, CancellationToken cancellationToken) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.Compilation.SerializeToPeStream(CommonPEModuleBuilder moduleBeingBuilt, EmitStreamProvider peStreamProvider, EmitStreamProvider metadataPEStreamProvider, EmitStreamProvider pdbStreamProvider, RebuildData rebuildData, Func`2 testSymWriterFactory, DiagnosticBag diagnostics, EmitOptions emitOptions, Nullable`1 privateKeyOpt, CancellationToken cancellationToken) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CommonCompiler.CompileAndEmit(TouchedFileLogger touchedFilesLogger, Compilation& compilation, ImmutableArray`1 analyzers, ImmutableArray`1 generators, ImmutableArray`1 additionalTextFiles, AnalyzerConfigSet analyzerConfigSet, ImmutableArray`1 sourceFileAnalyzerConfigOptions, ImmutableArray`1 embeddedTexts, DiagnosticBag diagnostics, ErrorLogger errorLogger, CancellationToken cancellationToken, CancellationTokenSource& analyzerCts, AnalyzerDriver& analyzerDriver, Nullable`1& generatorTimingInfo) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CommonCompiler.RunCore(TextWriter consoleOutput, ErrorLogger errorLogger, CancellationToken cancellationToken) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CommonCompiler.Run(TextWriter consoleOutput, CancellationToken cancellationToken) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CSharp.CommandLine.Csc.Run(String[] args, BuildPaths buildPaths, TextWriter textWriter, IAnalyzerAssemblyLoader analyzerLoader) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CommandLine.BuildClient.RunCompilation(IEnumerable`1 originalArguments, BuildPaths buildPaths, TextWriter textWriter, String pipeName) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CommandLine.BuildClient.Run(IEnumerable`1 arguments, RequestLanguage language, CompileFunc compileFunc, CompileOnServerFunc compileOnServerFunc, ICompilerServerLogger logger) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CSharp.CommandLine.Program.MainCore(String[] args) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]
    /__w/1/s/.dotnet/sdk/10.0.100-preview.6.25315.102/Roslyn/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.CSharp.CommandLine.Program.Main(String[] args) [/__w/1/s/src/source-build-reference-packages/src/externalPackages/src/spectre-console/artifacts/clone/src/Spectre.Console/Spectre.Console.csproj::TargetFramework=net10.0]

@akoeplinger
Copy link
Member

akoeplinger commented Jul 7, 2025

@MichaelSimons other jobs also fail with this:

[xUnit.net 00:00:00.34]       The following binaries were detected:
[xUnit.net 00:00:00.34]       src/source-build-reference-packages/src/externalPackages/src/spectre-console/docs/src/SocialCards/CascadiaCodePL.woff2
[xUnit.net 00:00:00.34]       src/source-build-reference-packages/src/externalPackages/src/spectre-console/docs/input/assets/CascadiaMonoPL.woff2
[xUnit.net 00:00:00.34]       src/source-build-reference-packages/src/externalPackages/src/spectre-console/docs/input/assets/images/table.mp4
[xUnit.net 00:00:00.34]       src/source-build-reference-packages/src/externalPackages/src/spectre-console/docs/input/assets/images/table.webm
[xUnit.net 00:00:00.34]       
[xUnit.net 00:00:00.34]       See https://github.com/dotnet/dotnet/blob/main/docs/VMR-Permissible-Sources.md for information on how to resolve these failures.

@MichaelSimons
Copy link
Member

@jjonescz, Was the work completed to take a dependency on this package? I ask because we have some reporting that is flagging the Spectre.Console/0.50.0 package as unreferenced. I am checking to see if the work is still in-flight to consume this, our reporting is incorrectly flagging this, or something else is going on.

@jjonescz
Copy link
Member Author

Not yet. Turned out we need some more process before ingesting the package in product (like security review) and so it might be postponed to .net 11 since it's not a huge priority.

@jjonescz
Copy link
Member Author

jjonescz commented Jul 30, 2025

Sorry if it's causing problems. Feel free to revert this PR (or I can do that, lmk) if that would help. Thanks.

jonathanpeppers pushed a commit to jonathanpeppers/source-build-reference-packages that referenced this pull request Oct 28, 2025
Context: dotnet#1287

* Update spectre-console submodule to 0.52.0

* Add patch file to delete problematic binaries:

dotnet#1287 (comment)

Co-authored-by: Jan Jones <[email protected]>
jonathanpeppers pushed a commit to jonathanpeppers/source-build-reference-packages that referenced this pull request Oct 28, 2025
Context: dotnet#1287

* Update spectre-console submodule to 0.52.0

* Add patch file to delete problematic binaries:

dotnet#1287 (comment)

Co-authored-by: Jan Jones <[email protected]>
jonathanpeppers pushed a commit to jonathanpeppers/source-build-reference-packages that referenced this pull request Oct 28, 2025
Context: dotnet#1287

* Update spectre-console submodule to 0.52.0

* Add patch file to delete problematic binaries:

dotnet#1287 (comment)

Co-authored-by: Jan Jones <[email protected]>
jonathanpeppers added a commit to dotnet/dotnet that referenced this pull request Oct 29, 2025
Context: dotnet/source-build-reference-packages#1447
Context: dotnet/source-build-reference-packages#1287 (comment)

The docs folder contains binary files, that are not needed for building from source.
jonathanpeppers pushed a commit to jonathanpeppers/source-build-reference-packages that referenced this pull request Oct 29, 2025
Context: dotnet#1287

* Update spectre-console submodule to 0.52.0

* Add patch file to delete problematic binaries:

dotnet#1287 (comment)

Co-authored-by: Jan Jones <[email protected]>
MichaelSimons pushed a commit that referenced this pull request Oct 30, 2025
* Add Spectre.Console 0.52.0 (#1287)

Context: #1287

* Update spectre-console submodule to 0.52.0

* Add patch file to delete problematic binaries:

#1287 (comment)

Co-authored-by: Jan Jones <[email protected]>

* Remove binary patch again

* Pin darc version

* Add DelaySign and PublicSign to build arguments

---------

Co-authored-by: Jan Jones <[email protected]>
Co-authored-by: Premek Vysoky <[email protected]>
Co-authored-by: Alexander Köplinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants