Ensure that --nologo adheres to DOTNET_NOLOGO if present
#51462
Merged
+502
−456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2025
baronfel
force-pushed
the
consistently-handle-dotnet-nologo
branch
from
d1db235 to
e08348f
Compare
baronfel
force-pushed
the
consistently-handle-dotnet-nologo
branch
from
183bc2e to
2a978ba
Compare
This was referenced Nov 5, 2025
baronfel
force-pushed
the
consistently-handle-dotnet-nologo
branch
2 times, most recently
from
6e8dbca to
5a0a79b
Compare
Member
Author
|
/ba-g known issue for helix issues on macOS |
3 tasks
MiYanni
approved these changes
Nov 8, 2025
baronfel
commented
Nov 8, 2025
…the DOTNET_NOLOGO environment variable
… `--nologo` when forwarding to MSBuild
…ption registration
…ren't modified by editorconfig, IDEs, or git.
baronfel
force-pushed
the
consistently-handle-dotnet-nologo
branch
from
3a52a49 to
afd951a
Compare
Member
Author
|
/ba-g known macos SSL issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the third bullet described in #12195 (comment) -
users were surprised that
dotnet msbuilddidn't respectDOTNET_NOLOGO. This is somewhat of a grey area sincedotnet msbuilddoesn't do much customization at all anyway, but this seemed harmless enough to take a crack at it.So overall this:
--nologoMSBuild conceptDOTNET_NOLOGOenvironment variableTo help work on this in VSCode, I also added a CLI-specific slnx. When loaded in VSCode, it drastically improves the experience of working on the repo. It's so impactful that I made it the default in the repo's settings.json. Without this, test discovery and execution may as well not work - the builds take so long.