Don't include runtime config info during publish #49394
Conversation
|
@dotnet/run-file for reviews |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a flag to skip including runtime configuration items when publishing, addressing issue #49368.
- Introduce
includeRuntimeConfigInformationparameter toWriteProjectFile - Set the flag based on
BuildTarget != "Publish"inCreateProjectRootElement - Wrap the runtimeconfig
<ItemGroup>generation in a conditional
| targetFilePath: EntryPointFileFullPath, | ||
| artifactsPath: GetArtifactsPath()); | ||
| artifactsPath: GetArtifactsPath(), | ||
| includeRuntimeConfigInformation: BuildTarget != "Publish"); |
There was a problem hiding this comment.
Use a case-insensitive comparison when checking BuildTarget to avoid unexpected mismatches. For example: !string.Equals(BuildTarget, "Publish", StringComparison.OrdinalIgnoreCase).
| includeRuntimeConfigInformation: BuildTarget != "Publish"); | |
| includeRuntimeConfigInformation: !string.Equals(BuildTarget, "Publish", StringComparison.OrdinalIgnoreCase)); |
| targetFilePath: EntryPointFileFullPath, | ||
| artifactsPath: GetArtifactsPath()); | ||
| artifactsPath: GetArtifactsPath(), | ||
| includeRuntimeConfigInformation: BuildTarget != "Publish"); |
There was a problem hiding this comment.
[nitpick] Extract the literal "Publish" into a named constant or enum to eliminate a magic string and improve maintainability.
| includeRuntimeConfigInformation: BuildTarget != "Publish"); | |
| includeRuntimeConfigInformation: BuildTarget != BuildTargets.Publish); |
|
|
||
| var targetDirectory = Path.GetDirectoryName(targetFilePath) ?? ""; | ||
| writer.WriteLine($""" | ||
| if (includeRuntimeConfigInformation) |
There was a problem hiding this comment.
Add unit tests covering both paths of includeRuntimeConfigInformation (true and false) to verify the runtime config <ItemGroup> is correctly included or omitted. Use the Fact Skip parameter to reference issue #49368.
2 participants
Fixes #49368