Skip to content

Conversation

@layomia
Copy link
Contributor

@layomia layomia commented Aug 22, 2023

This follows the approach of the request delegate generator. The corresponding runtime change that switches the generator to use the compiler feature is dotnet/runtime#90835.

The runtime change has been approved by tactics for RC-1, and this SDK completes the scenario.

@layomia layomia added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Aug 22, 2023
@layomia layomia added this to the .NET 8.0 milestone Aug 22, 2023
@layomia layomia self-assigned this Aug 22, 2023
@layomia layomia requested a review from vijayrkn as a code owner August 22, 2023 17:57
@ghost ghost added the untriaged Request triage from a team member label Aug 22, 2023
@ghost
Copy link

ghost commented Aug 22, 2023

Thanks for your PR, @layomia.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eerhardt
Copy link
Member

You'll want to target release/8.0.1xx-rc1 to get this into RC1.

@layomia layomia changed the base branch from release/8.0.1xx to release/8.0.1xx-rc1 August 22, 2023 20:58
@layomia layomia requested review from a team, andriipatsula and joperezr as code owners August 22, 2023 20:58
@layomia layomia changed the base branch from release/8.0.1xx-rc1 to release/8.0.1xx August 22, 2023 20:59
@layomia layomia force-pushed the enable-interceptors-binding branch from 3f04349 to cc315a8 Compare August 22, 2023 21:07
@layomia layomia changed the base branch from release/8.0.1xx to release/8.0.1xx-rc1 August 22, 2023 21:07
@layomia layomia requested review from marcpopMSFT and removed request for a team, andriipatsula, joperezr and vijayrkn August 22, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants