Skip to content

[main] Update dependencies from dotnet/msbuild #34119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 24, 2023
Merged

[main] Update dependencies from dotnet/msbuild #34119

merged 4 commits into from
Jul 24, 2023

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 20, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

  • Subscription: 51256791-e30b-4b96-f2b9-08daf1d75f3f
  • Build: 20230721.2
  • Date Produced: July 21, 2023 2:24:34 AM UTC
  • Commit: 7816f5e89b30995d2954cfa54f147f4415cc5005
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2023…
4dc7416 
…0719.1

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.8.0-preview-23367-03 -> To Version 17.8.0-preview-23369-01
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Jul 20, 2023
@MiYanni
Copy link
Member

MiYanni commented Jul 20, 2023

@dotnet/source-build-internal There seems to be a new pre-built for System.Text.Json because the version was updated. I looked over the directions but I wasn't exactly sure how to proceed. Is it simply a DARC dependency I need to add? Any help would be appreciated.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2023…
2417354 
…0721.2

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.8.0-preview-23367-03 -> To Version 17.8.0-preview-23371-02
@mthalman
Copy link
Member

mthalman commented Jul 21, 2023

@dotnet/source-build-internal There seems to be a new pre-built for System.Text.Json because the version was updated. I looked over the directions but I wasn't exactly sure how to proceed. Is it simply a DARC dependency I need to add? Any help would be appreciated.

I guess the first question is why is it necessary to reference 7.0.3 instead of 7.0.2?

If you want to reference it, that versions needs to be added to the SBRP repo. Please following the instructions in the readme there for how to do that.

@Forgind
Copy link
Contributor

Forgind commented Jul 21, 2023

@dotnet/source-build-internal There seems to be a new pre-built for System.Text.Json because the version was updated. I looked over the directions but I wasn't exactly sure how to proceed. Is it simply a DARC dependency I need to add? Any help would be appreciated.

I guess the first question is why is it necessary to reference 7.0.3 instead of 7.0.2?

If you want to reference it, that versions needs to be added to the SBRP repo. Please following the instructions in the readme there for how to do that.

Because MSBuild now references 7.0.3.

/cc: @rainersigwald for why MSBuild needs 7.0.3.

@rainersigwald
Copy link
Member

rainersigwald commented Jul 21, 2023

I guess the first question is why is it necessary to reference 7.0.3 instead of 7.0.2?

VS updated to 7.0.3 and asked us to follow suit. We could theoretically diverge on a core/framework axis, if that would be a big help to sourcebuild.

@v-wuzhai v-wuzhai mentioned this pull request Jul 24, 2023
Closed
@v-wuzhai v-wuzhai enabled auto-merge July 24, 2023 09:59
@v-wuzhai v-wuzhai merged commit 13b8781 into main Jul 24, 2023
@v-wuzhai v-wuzhai deleted the darc-main-e04ddca9-90a5-4ba9-96f0-262acd1ba3f5 branch July 24, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiYanni MiYanni MiYanni approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow source-build untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MiYanni @mthalman @Forgind @rainersigwald @v-wuzhai @marcpopMSFT