Check RuntimeIdentifiers in Asserts for Implicit RID Resolution #28005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
nagilson
changed the title
Member
Author
|
@MichaelSimons Confirmed this should fix source-build. rc2 is blocked by this, requesting review from @dsplaisted . |
MichaelSimons
approved these changes
Sep 19, 2022
Member
MichaelSimons
left a comment
MichaelSimons
left a comment
There was a problem hiding this comment.
From a source-build perspective this solve the blocking issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #27985. I thought RuntimeIdentifier would be filled from RuntimeIdentifiers so the assert would be OK but that was incorrect.
Risk of change:
Low
Reason for Change:
Unblocks Source-build by removing an assert that didn't consider a specific edge-case and caused an unnecessary failure.
Backport to the primary 7.0.1xx branch #28006