Skip to content

[browser][MT] fix Promise cancelation race condition #99259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 6, 2024
Merged

[browser][MT] fix Promise cancelation race condition #99259

merged 6 commits into from
Mar 6, 2024

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Mar 4, 2024 •
edited
Loading

  • moved more logic to PromiseHolder on js side.
  • introduced shared memory PromiseHolderState with IsResolving state
  • implemented compareExchangeI32 and use it to signal which side will resolve the Promise/Task

Contributes to #98721

@pavelsavara
- moved more logic to PromiseHolder
e884d2c 
- introduced shared memory PromiseHolderState with IsResolving state
- implemeted compareExchangeI32 and use it to signal which side will resove the Promise/Task
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Mar 4, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Mar 4, 2024
@pavelsavara pavelsavara requested review from kg and maraf March 4, 2024 20:03
@pavelsavara pavelsavara self-assigned this Mar 4, 2024
@ghost
Copy link

ghost commented Mar 4, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • moved more logic to PromiseHolder
  • introduced shared memory PromiseHolderState with IsResolving state
  • implemeted compareExchangeI32 and use it to signal which side will resove the Promise/Task

Contributes to #98721

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

@pavelsavara
Copy link
Member Author

pavelsavara commented Mar 4, 2024

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 4, 2024

Azure Pipelines successfully started running 1 pipeline(s).

kg
kg reviewed Mar 4, 2024
View reviewed changes
kg
kg reviewed Mar 4, 2024
View reviewed changes
kg
kg reviewed Mar 4, 2024
View reviewed changes
kg
kg reviewed Mar 4, 2024
View reviewed changes
This was referenced Mar 4, 2024
Closed
Open
Closed
@build-analysis build-analysis bot mentioned this pull request Mar 5, 2024
Open
3 tasks
@pavelsavara pavelsavara marked this pull request as ready for review March 5, 2024 13:37
@pavelsavara pavelsavara requested a review from lewing as a code owner March 5, 2024 13:37
This was referenced Mar 5, 2024
Closed
Closed
This was referenced Mar 5, 2024
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Mar 6, 2024
Closed
@pavelsavara
Copy link
Member Author

pavelsavara commented Mar 6, 2024

The CI failure is #98406

@pavelsavara pavelsavara merged commit 7183d70 into dotnet:main Mar 6, 2024
@pavelsavara pavelsavara deleted the browser_cancelation_handle branch March 6, 2024 14:17
@pavelsavara
Copy link
Member Author

pavelsavara commented Mar 7, 2024

This didn't 100% help Log

@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kg kg kg approved these changes

@maraf maraf Awaiting requested review from maraf

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pavelsavara @kg