Skip to content

Enable QueueUserAPC2 suspension even without CET #99076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

Enable QueueUserAPC2 suspension even without CET #99076

merged 1 commit into from
Feb 28, 2024

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Feb 28, 2024

No description provided.

@jkotas jkotas requested review from VSadov and kouvel February 28, 2024 19:56
@ghost ghost assigned jkotas Feb 28, 2024
@ghost ghost added the area-VM-coreclr label Feb 28, 2024
@jkotas
Copy link
Member Author

jkotas commented Feb 28, 2024

I think have QueueUserAPC2-based suspension enable for native AOT unconditionally. We should do the same for regular CoreCLR.

@VSadov
Copy link
Member

VSadov commented Feb 28, 2024 •
edited
Loading

I think have QueueUserAPC2-based suspension enable for native AOT unconditionally. We should do the same for regular CoreCLR.

Yes, QueueUserAPC2 scales a lot better than linear one-by-one thread suspension.
The comment had "once had .. enough bake time". I think we had enough of that by now.

VSadov
VSadov approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@build-analysis build-analysis bot mentioned this pull request Feb 28, 2024
Closed
@jkotas jkotas merged commit dac4446 into dotnet:main Feb 28, 2024
@jkotas jkotas deleted the EnableAPC2 branch February 28, 2024 23:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@VSadov VSadov VSadov approved these changes

+1 more reviewer

@kouvel kouvel kouvel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jkotas jkotas

Labels

area-VM-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkotas @VSadov @kouvel