Skip to content

Conversation

@ghost ghost added the area-Meta label Feb 16, 2024
@ghost
Copy link

ghost commented Feb 16, 2024

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

https://github.com/dotnet/runtime/blob/3a8b129e324e79dac1e41771b5fbf99fcede649d/src/native/external/rapidjson-version.txt#L5-L6

Author: am11
Assignees: -
Labels:

area-Meta

Milestone: -

@am11 am11 added area-Host and removed area-Meta labels Feb 16, 2024
@am11 am11 requested review from elinor-fung and janvorli February 16, 2024 20:36
@ghost
Copy link

ghost commented Feb 16, 2024

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

https://github.com/dotnet/runtime/blob/3a8b129e324e79dac1e41771b5fbf99fcede649d/src/native/external/rapidjson-version.txt#L5-L6

Author: am11
Assignees: -
Labels:

area-Host

Milestone: -

@am11
Copy link
Member Author

am11 commented Feb 17, 2024

Remaining failures are unrelated.

This is the first update since dotnet/core-setup#7708. I have deleted the unused code and adjusted the note in subproject's readme. I know this is not the convention we are using in other vendor libs (we copy the whole repo snapshot), but we are anyway having portion of rapidjson in runtime's main.

@teo-tsirpanis teo-tsirpanis added the community-contribution Indicates that the PR has been added by a community member label Feb 17, 2024
Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elinor-fung elinor-fung merged commit 7a9ce63 into dotnet:main Feb 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Host community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants