[release/8.0-staging] [browser][fix] maxParallelDownloads #95870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
kg,
lewing and
pavelsavara
as code owners
ghost
added
the
lewing
approved these changes
Dec 11, 2023
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #95793 to release/8.0-staging /cc @lewing @pavelsavara Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
Member
Member
|
@MackinnonBuck please update the impact section with any details on customer reports that you have |
MackinnonBuck
approved these changes
Dec 12, 2023
lewing
added
Servicing-approved
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #95793 to release/8.0-staging
/cc @lewing @pavelsavara
Customer Impact
Fixes #95491 by respecting the parallelism settings in all cases. The issue was reported by the aspnetcore team around IO starvation for signalr connections while the webassembly assets were downloaded. More context has been added below:
Some Blazor customers have been indicating that when using the Auto render mode feature, the app's user experience gets degraded, often to the extent that the app does not become usable until the download of WebAssembly resources completes. This is especially true when the network connection quality is poor. We've experimented with ways to address this, and the most effective method we've found has been to throttle the download of WebAssembly assets. We gave customers a way to try out this fix, and they've indicated that it addresses the problems they've been experiencing. Lots of the customer engagement around this issue can be found in dotnet/aspnetcore#52154.
By fixing the
maxParallelDownloadsbug, we can make the corresponding change in Blazor to throttle the downloading of WebAssembly resources so the rest of the app can retain functionality.Testing
Manual testing
Risk
Low