[release/8.0-staging] [mono][jit] Fix the bblock check in the box+callvirt optimization. #95500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
SamMonoRT,
lambdageek and
vargaz
as code owners
ghost
added
the
kg
approved these changes
Dec 1, 2023
Contributor
|
hope this can release in 8.0.1 release |
lambdageek
approved these changes
Dec 1, 2023
leecow
added
Servicing-approved
Member
|
@vargaz - this is approved. Are we waiting on any other work here or can this be merged? |
vargaz
approved these changes
Dec 6, 2023
Contributor
|
It can be merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #95443 to release/8.0-staging
/cc @vargaz
Customer Impact
The following code returns an incorrect result due to a faulty JIT optimization:
This is a regression from 7.0. The original customer report is:
#95347
Testing
The PR includes a regression test.
Risk
Low, only affects mono based platforms.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.