[release/8.0-staging] [mono][debugger] If debugger is disconnected but vm is not exited restart the debugger thread #95270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @thaystg Issue DetailsBackport of #95266 to release/8.0-staging /cc @thaystg Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
lambdageek
approved these changes
Nov 27, 2023
thaystg
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #95266 to release/8.0-staging
/cc @thaystg
Customer Impact
Using rider after detach the debugger, the IDE cannot attach again in the same process running using mono runtime.
Testing
Manual tested.
Risk
Low risk. Only inverting the condition to decide if the debugger_thread will be restarted.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.