Provide System.Text.Encodings.Web package readme #94637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-text-encodings-web Issue DetailsFill out details for the See #92228
|
tarekgh
approved these changes
Nov 11, 2023
Member
tarekgh
left a comment
tarekgh
left a comment
There was a problem hiding this comment.
Looks good. Thanks @eNeRGy164 for your help with this issue.
ViktorHofer
reviewed
Nov 12, 2023
| using System.Text.Encodings.Web; | ||
| using System.Text.Unicode; | ||
|
|
||
| TextEncoderSettings customEncoderSettings = new TextEncoderSettings(); |
Member
There was a problem hiding this comment.
nit: it would be good to use the simplified new operator on the right hand side: new();
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fill out details for the
System.Text.Encodings.WebNuGet package readme.See #92228