Skip to content

Implements new intand long overloads for TimeSpan #94143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Implements new intand long overloads for TimeSpan #94143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c78cde4
Implements new `int`and `long` overloads for `TimeSpan`
tcortega Oct 28, 2023
7a24f9c
Refactors code and fixes build errors
tcortega Oct 29, 2023
bfc99de
Addresses StyleCop errors
tcortega Oct 29, 2023
8148be4
Removes trailing whitespace to fix StyleCop error
tcortega Oct 29, 2023
556484c
Merge branch 'main' into timespan-int-overloads
tcortega Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/TimeSpan.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,18 @@ private static TimeSpan IntervalFromDoubleTicks(double ticks)

public static TimeSpan FromMilliseconds(double value) => Interval(value, TicksPerMillisecond);

public static TimeSpan FromMilliseconds(long milliseconds)
{
return new TimeSpan(milliseconds * TicksPerMillisecond);
}

public static TimeSpan FromMilliseconds(long milliseconds, long microseconds = 0)
{
long totalTicks = milliseconds * TicksPerMillisecond
+ microseconds * TicksPerMicrosecond;
return new TimeSpan(totalTicks);
}

/// <summary>
/// Returns a <see cref="TimeSpan"/> that represents a specified number of microseconds.
/// </summary>
Expand Down
11 changes: 11 additions & 0 deletions src/libraries/System.Runtime/ref/System.Runtime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5606,6 +5606,17 @@ public TimeoutException(string? message, System.Exception? innerException) { }
public static System.TimeSpan FromMilliseconds(double value) { throw null; }
public static System.TimeSpan FromMinutes(double value) { throw null; }
public static System.TimeSpan FromSeconds(double value) { throw null; }
public static System.TimeSpan FromDays(int days) { throw null; }
public static System.TimeSpan FromDays(int days, int hours = 0, long minutes = 0, long seconds = 0, long milliseconds = 0, long microseconds = 0) { throw null; }
public static System.TimeSpan FromHours(int hours) { throw null; }
public static System.TimeSpan FromHours(int hours, long minutes = 0, long seconds = 0, long milliseconds = 0, long microseconds = 0) { throw null; }
public static System.TimeSpan FromMinutes(long minutes) { throw null; }
public static System.TimeSpan FromMinutes(long minutes, long seconds = 0, long milliseconds = 0, long microseconds = 0) { throw null; }
public static System.TimeSpan FromSeconds(long seconds) { throw null; }
public static System.TimeSpan FromSeconds(long seconds, long milliseconds = 0, long microseconds = 0) { throw null; }
public static System.TimeSpan FromMilliseconds(long milliseconds) { throw null; }
public static System.TimeSpan FromMilliseconds(long milliseconds, long microseconds = 0) { throw null; }
public static System.TimeSpan FromMicroseconds(long microseconds) { throw null; }
public static System.TimeSpan FromTicks(long value) { throw null; }
public override int GetHashCode() { throw null; }
public System.TimeSpan Multiply(double factor) { throw null; }
Expand Down