- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.2k
[mono][debugger] Improve debugger features #94066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
         thaystg
  
      
      
      commented
      
            thaystg
  
      
      
      commented
        Oct 26, 2023 
      
    
  
- Creating new messages
- Fixing some messages or adding extra information.
- Fixing when jit_end is called while running a invoke_method
… called while running a invoke_method
| Tagging subscribers to this area: @thaystg Issue Details
 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
- A couple of places that look at MonoClassField:typeneed hot reload protection.
- It would be better if we didn't copy/paste the code from ves_icall_System_Runtime_CompilerServices_RuntimeHelpers_GetSpanDataFrom
- The new MDBGPROT_CMD_APPDOMAIN_GET_TYPEcommand is kind of weird - I wonder if you can specialize it only for arrays (so it errors out iftypeis notMONO_TYPE_SZARRAY||MONO_TYPE_ARRAY). Or is this supposed to emulate some CoreCLR behavior (in that case, please add a comment that it has to do it in this weird way)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, except one error case that should return an error code.
also I think "get type" is not a good name for a command that creates an array type (but it's ok if you want to leave it)
| buffer_add_objid (buf, o); | ||
| break; | ||
| } | ||
| case MDBGPROT_CMD_APPDOMAIN_GET_TYPE: { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it it only works on arrays? why is it called "get type" and not something like "create array type"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works also for pointers, but I'm not sure how to implement it yet, that is why I didn't implement.