[mono] Simplify of OffsetToStringData as it's done on coreclr #93987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaystg
requested review from
BrzVlad,
SamMonoRT,
kotlarmilos,
lambdageek,
marek-safar and
vargaz
as code owners
|
Looks ok, but why is this useful ? |
vargaz
approved these changes
Oct 25, 2023
vargaz
reviewed
Oct 25, 2023
src/mono/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.Mono.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Oct 26, 2023
src/mono/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.Mono.cs
Outdated
Show resolved
Hide resolved
lambdageek
approved these changes
Oct 26, 2023
src/mono/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.Mono.cs
Outdated
Show resolved
Hide resolved
This was referenced Oct 26, 2023
lambdageek
approved these changes
Oct 26, 2023
|
@lambdageek it looks like this is causing performance issues, should we revert? |
|
@thaystg It looks like the interpreter regressed. Maybe put back the interpreter intrinsic? I guess for some reason it's not inlining that getter method and the constant? or maybe add |
liveans
pushed a commit
to liveans/dotnet-runtime
that referenced
this pull request
Nov 9, 2023
…#93987) * Change implementation of OffsetToStringData as it's done on coreclr * Fix comment * Remove more comments * completely remove the comments * Update RuntimeHelpers.Mono.cs * Addressing comments * Addressing @lambdageek comment.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.