remove extra assert from WinHttp handler #93984
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it seems like the callback can be called multiple times - perhaps because of TLS 1.3.
With that, it is called and then it is set to null in
CreateResponseMessageruntime/src/libraries/System.Net.Http.WinHttpHandler/src/System/Net/Http/WinHttpResponseParser.cs
Line 67 in 9ad24ae
It seems like this is only problem with
Debugbuild. All the methods insideOnRequestSendingRequestcan handlenullRequestHandlewithout crashing. However the processing seems unnecessary so I simply removed the assert and return from the method under this condition.This was somewhat easy to reproduce on my Windows VM. After the change all tests are passing e.g. the Assert really seems unnecessary.
fixes #93099