Skip to content

(chore) set min version of cmake in native CmakeLists.txt to surpass Cmake CMP0000 policy warning #93437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 14, 2023
Merged

(chore) set min version of cmake in native CmakeLists.txt to surpass Cmake CMP0000 policy warning #93437

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
88771c7
(chore) set min version of cmake in native CmakeLists.txt to surpass …
Neo-vortex Oct 13, 2023
897660b
(chore) set all cmake versions according to native/libs/CMakeLists.txt
Neo-vortex Oct 13, 2023
b70c99e
Apply suggestions from code review
jkotas Oct 13, 2023
41c0f68
Update src/native/libs/System.Security.Cryptography.Native/CMakeLists…
jkotas Oct 13, 2023
a8bcbae
Update src/native/libs/System.Globalization.Native/CMakeLists.txt
Neo-vortex Oct 13, 2023
0f7a6ec
Update src/native/libs/System.Security.Cryptography.Native/CMakeLists…
Neo-vortex Oct 13, 2023
47efbe4
(chore) set min version for cmake to 3.16
Neo-vortex Oct 13, 2023
2872c7a
(chore) set min cmae version to 3.10
Neo-vortex Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/native/libs/System.Globalization.Native/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Required for StaticICULinking
cmake_minimum_required(VERSION 3.16...3.20)
Copy link
Member

@am11 am11 Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when we have > 3.20 installed? Do we want to restrict on max value or can it just be set to 3.16 minimum?

Copy link
Contributor Author

@Neo-vortex Neo-vortex Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right.
limiting the max version is probably not what we want to do.
we can set cmake_minimum_required(VERSION 3.16)
fixed in the latest commit

Copy link
Member

@jkoritzinsky jkoritzinsky Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not setting a max version. This is setting the version of CMake to set the policy values for. Setting it to 3.20 ensures that for the dotnet/runtime build, we use a consistent set of CMake policy configurations.


project(System.Globalization.Native C)

if(CLR_CMAKE_TARGET_UNIX OR CLR_CMAKE_TARGET_WASI)
Expand Down
3 changes: 3 additions & 0 deletions src/native/libs/System.Security.Cryptography.Native/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Required for StaticOpenSslLinking
cmake_minimum_required(VERSION 3.16...3.20)

project(System.Security.Cryptography.Native C)

# These are happening inside of OpenSSL-defined macros out of our control
Expand Down