Skip to content

Add net8 wasi workload tests #92653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Add net8 wasi workload tests #92653

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
92bf1e2
Add net8 wasi workload tests
lewing Sep 26, 2023
0ac84d0
Update eng/testing/tests.wasi.targets
lewing Sep 26, 2023
a87d950
[wasm] CI: trigger WBT on changes to eng/testing/tests.{browser,wasm,…
radical Sep 26, 2023
9bf6819
Update eng/testing/tests.wasi.targets
lewing Sep 26, 2023
5f72a2e
Alias the net8 runtime pack correctly
lewing Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion eng/testing/tests.wasi.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,12 @@
ManifestName="Microsoft.NET.Workload.Mono.ToolChain.Current"
Variant="latest"
Version="$(PackageVersionForWorkloadManifests)" />
<WorkloadCombinationsToInstall Include="latest" Variants="latest" />

<WorkloadIdForTesting Include="wasi-experimental-net8,wasi-experimental"
Copy link
Member

@radical radical Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be what you need

      <WorkloadIdForTesting Include="wasi-experimental"
                            ManifestName="Microsoft.NET.Workload.Mono.ToolChain.Current"
                            Variant="latest"
                            Version="$(PackageVersionForWorkloadManifests)" />
      <WorkloadIdForTesting Include="wasi-experimental-net8"
                            ManifestName="Microsoft.NET.Workload.Mono.ToolChain.net8"
                            Variant="net8"
                            Version="$(PackageVersionForWorkloadManifests)" />

Copy link
Member Author

@lewing lewing Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason I had both is that wasi-experimental-net8 depends on wasi-experimental and I'm not sure the sdk preparation logic is smart enough to understand the dependency

ManifestName="Microsoft.NET.Workload.Mono.ToolChain.net8"
Variant="net8"
Version="$(PackageVersionForWorkloadManifests)" />
<WorkloadCombinationsToInstall Include="latest" Variants="latest,net8" />
</ItemGroup>
</Target>
</Project>