Skip to content

Avoiding trying to load the native library Microsoft.DiaSymReader.Native.<arch>.dll on Linux #92492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 27, 2023
Merged

Avoiding trying to load the native library Microsoft.DiaSymReader.Native.<arch>.dll on Linux #92492

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4a7178a
92278_prevent_load_win_dll_on_linux: do not need to probe for Microso…
Sep 22, 2023
5f4cbd8
added comment
Sep 22, 2023
b9fef19
92278: revert ceeload.cpp changes
Sep 22, 2023
2e0f4f4
92278: add DFEATURE_ISYM_READER definition only for windows
Sep 22, 2023
15dfda4
Merge branch 'main' into 92278_prevent_load_win_dll_on_linux
neyromant Sep 23, 2023
ad7b564
Update src/coreclr/clrdefinitions.cmake
jkotas Sep 23, 2023
2379687
Update clrdefinitions.cmake
neyromant Sep 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/coreclr/vm/ceeload.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2265,6 +2265,13 @@ ISymUnmanagedReader *Module::GetISymUnmanagedReader(void)
{
RETURN (NULL);
}

#if defined(__linux__) || defined(__APPLE__) || defined(__FreeBSD__)
// Because NATIVE_SYMBOL_READER_DLL is a window-only library, an attempt to load it is guaranteed to fail.
// Let's not do this
RETURN (NULL);
#endif //defined(__linux__) || defined(__APPLE__) || defined(__FreeBSD__)

symbolReaderPath.Append(NATIVE_SYMBOL_READER_DLL);
hr = FakeCoCreateInstanceEx(CLSID_CorSymBinder_SxS, symbolReaderPath.GetUnicode(), IID_ISymUnmanagedBinder, (void**)&pBinder, NULL);
if (FAILED(hr))
Expand Down