Skip to content

[wasm] Fix performance-setup.sh to track change in BDN #92067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2023
Merged

[wasm] Fix performance-setup.sh to track change in BDN #92067

merged 2 commits into from
Sep 14, 2023

Conversation

@radical
Copy link
Member

@radical radical commented Sep 14, 2023

dotnet/performance got an update for dotnet/BenchmarkDotNet via
dotnet/performance#3331 . And that bdn update
includes dotnet/BenchmarkDotNet#2375, which
subtly changes how the arguments get parsed, and breaks the existing
scripts:

$ pushd "/home/helixbot/work/B807097D/w/AED609DF/e/performance/artifacts/bin/for-running/MicroBenchmarks"
$ dotnet exec MicroBenchmarks.dll --wasmArgs "--experimental-wasm-eh --expose_wasm --module" ...
MicroBenchmarks 1.0.0-dev
© Microsoft Corporation. All rights reserved.

ERROR(S):
  Option 'experimental-wasm-eh --expose_wasm --module' is unknown.

Fixes #92066 .

@radical
[wasm] Fix performance-setup.sh to track change in BDN
fcb5808 
`dotnet/performance` got an update for `dotnet/BenchmarkDotNet` via
dotnet/performance#3331 . And that bdn update
includes dotnet/BenchmarkDotNet#2375, which
subtly changes how the arguments get parsed, and breaks the existing
scripts:

```
$ pushd "/home/helixbot/work/B807097D/w/AED609DF/e/performance/artifacts/bin/for-running/MicroBenchmarks"
$ dotnet exec MicroBenchmarks.dll --wasmArgs "--experimental-wasm-eh --expose_wasm --module" ...
MicroBenchmarks 1.0.0-dev
© Microsoft Corporation. All rights reserved.

ERROR(S):
  Option 'experimental-wasm-eh --expose_wasm --module' is unknown.
```

Fixes dotnet#92066 .
@radical radical added the arch-wasm WebAssembly architecture label Sep 14, 2023
@ghost ghost assigned radical Sep 14, 2023
@ghost
Copy link

ghost commented Sep 14, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

dotnet/performance got an update for dotnet/BenchmarkDotNet via
dotnet/performance#3331 . And that bdn update
includes dotnet/BenchmarkDotNet#2375, which
subtly changes how the arguments get parsed, and breaks the existing
scripts:

$ pushd "/home/helixbot/work/B807097D/w/AED609DF/e/performance/artifacts/bin/for-running/MicroBenchmarks"
$ dotnet exec MicroBenchmarks.dll --wasmArgs "--experimental-wasm-eh --expose_wasm --module" ...
MicroBenchmarks 1.0.0-dev
© Microsoft Corporation. All rights reserved.

ERROR(S):
  Option 'experimental-wasm-eh --expose_wasm --module' is unknown.

Fixes #92066 .

Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@radical
Copy link
Member Author

radical commented Sep 14, 2023

Test run - https://dev.azure.com/dnceng/internal/_build/results?buildId=2267326 . I will stop that once any one of the microbenchmarks run successfully.

@radical radical added area-Infrastructure-mono perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines labels Sep 14, 2023
@ghost
Copy link

ghost commented Sep 14, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

dotnet/performance got an update for dotnet/BenchmarkDotNet via
dotnet/performance#3331 . And that bdn update
includes dotnet/BenchmarkDotNet#2375, which
subtly changes how the arguments get parsed, and breaks the existing
scripts:

$ pushd "/home/helixbot/work/B807097D/w/AED609DF/e/performance/artifacts/bin/for-running/MicroBenchmarks"
$ dotnet exec MicroBenchmarks.dll --wasmArgs "--experimental-wasm-eh --expose_wasm --module" ...
MicroBenchmarks 1.0.0-dev
© Microsoft Corporation. All rights reserved.

ERROR(S):
  Option 'experimental-wasm-eh --expose_wasm --module' is unknown.

Fixes #92066 .

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-libraries, area-Infrastructure-mono, perf-pipeline
Milestone: -

LoopedBard3
LoopedBard3 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@radical
Copy link
Member Author

radical commented Sep 14, 2023

Successful test run in https://dev.azure.com/dnceng/internal/_build/results?buildId=2267699 .

@radical
Copy link
Member Author

radical commented Sep 14, 2023

Merging to unblock the pipeline, and the CI checks here won't be testing the changes anyway.

@radical radical merged commit 088f162 into dotnet:main Sep 14, 2023
@radical radical deleted the fix-perf-pipeline-args branch September 14, 2023 22:54
@build-analysis build-analysis bot mentioned this pull request Sep 15, 2023
Open
2 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cincuranet cincuranet cincuranet approved these changes

@LoopedBard3 LoopedBard3 LoopedBard3 approved these changes

@lewing lewing Awaiting requested review from lewing

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Infrastructure-mono perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasm] Perf pipeline broken due to the latest BDN update

3 participants

@radical @cincuranet @LoopedBard3