Skip to content

Improve filtering of candidate binding invocations in config binder gen #90619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 17, 2023
Merged

Improve filtering of candidate binding invocations in config binder gen #90619

merged 5 commits into from
Aug 17, 2023
+31 −46

Conversation

@layomia
Copy link
Contributor

@layomia layomia commented Aug 15, 2023

Address #89587 (comment).

@layomia layomia added this to the 8.0.0 milestone Aug 15, 2023
@layomia layomia self-assigned this Aug 15, 2023
This was referenced Aug 15, 2023
Merged
Closed
@ghost
Copy link

ghost commented Aug 15, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Address #89587 (comment).

Author: layomia
Assignees: layomia
Labels:

area-Extensions-Configuration
Milestone: 8.0.0

@layomia layomia force-pushed the binder-gen-parsing branch from 2630523 to 969f192 Compare August 15, 2023 19:57
@layomia layomia force-pushed the binder-gen-parsing branch from 969f192 to 28ec242 Compare August 15, 2023 20:57
@build-analysis build-analysis bot mentioned this pull request Aug 16, 2023
Closed
eiriktsarpalis
eiriktsarpalis reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structurally the change looks good, but I had a few questions about the details.

@layomia layomia force-pushed the binder-gen-parsing branch 2 times, most recently from 48c4762 to 31a561a Compare August 16, 2023 17:37
@layomia layomia force-pushed the binder-gen-parsing branch from 31a561a to 81bf579 Compare August 16, 2023 17:39
eiriktsarpalis
eiriktsarpalis approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Layomi!

@layomia layomia mentioned this pull request Aug 16, 2023
Closed
@layomia
Copy link
Contributor Author

layomia commented Aug 16, 2023

NameSyntax clause is causing test failures; reverted in 339bcb9. Will address in #90687.

@layomia layomia merged commit 22a4ff3 into dotnet:main Aug 17, 2023
@layomia
Copy link
Contributor Author

layomia commented Aug 17, 2023

/backport to release/8.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/8.0-rc1: https://github.com/dotnet/runtime/actions/runs/5892715423

@layomia layomia mentioned this pull request Aug 17, 2023
Merged
@github-actions github-actions bot mentioned this pull request Aug 17, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@CyrusNajmabadi CyrusNajmabadi Awaiting requested review from CyrusNajmabadi

@tarekgh tarekgh Awaiting requested review from tarekgh

Assignees

@layomia layomia

Labels

area-Extensions-Configuration

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@layomia @eiriktsarpalis