Skip to content

only slice SocketAddress on success operation #90284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 11, 2023
Merged

only slice SocketAddress on success operation #90284

merged 5 commits into from
Aug 11, 2023

Conversation

@wfurt
Copy link
Member

@wfurt wfurt commented Aug 10, 2023

This is regression from #88970.
When the SocketPal.TryCompleteReceiveFrom fails e.g. no data yet, we should not Slice the SocketAddress because on next round we would not have buffer to receive to. (as we do in case just bellow)
This was added to avoid tracking SocketAddressLength as separate parameter.

Change is UpdateReceivedSocketAddress is small cleanup as we do not need to special case it any more.

fixes #90125

@wfurt wfurt added this to the 6.0.x milestone Aug 10, 2023
@wfurt wfurt requested review from MihaZupan and stephentoub August 10, 2023 00:19
@wfurt wfurt self-assigned this Aug 10, 2023
@ghost
Copy link

ghost commented Aug 10, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This is regression from #88970.
When the SocketPal.TryCompleteReceiveFrom fails e.g. no data yet, we should not Slice the SocketAddress because on next round we would not have buffer to receive to. (as we do in case just bellow)
This was added to avoid tracking SocketAddressLength as separate parameter.

Change is UpdateReceivedSocketAddress is small cleanup as we do not need to special case it any more.

fixes #90125

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Sockets
Milestone: 6.0.x

@wfurt
Copy link
Member Author

wfurt commented Aug 10, 2023

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 10, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Aug 10, 2023
Closed
@wfurt
Copy link
Member Author

wfurt commented Aug 10, 2023

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 10, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@wfurt
Copy link
Member Author

wfurt commented Aug 10, 2023

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 10, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@wfurt
Copy link
Member Author

wfurt commented Aug 10, 2023

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 10, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@wfurt wfurt modified the milestones: 6.0.x, 8.0.0 Aug 10, 2023
@wfurt
Copy link
Member Author

wfurt commented Aug 11, 2023

outerloop test failures are unrelated.

@wfurt wfurt merged commit caaed61 into dotnet:main Aug 11, 2023
@wfurt wfurt deleted the SocketAddressSlice branch August 11, 2023 01:28
@build-analysis build-analysis bot mentioned this pull request Aug 12, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

@MihaZupan MihaZupan MihaZupan approved these changes

Assignees

@wfurt wfurt

Labels

area-System.Net.Sockets

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Socket UDP test failures due to endpoint mismatches

3 participants

@wfurt @stephentoub @MihaZupan